Bug 166997 – background-repeat-x doesn't work

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Myles C. Maxfield]

Created attachment 298723 [details]
Reproduction

See reproduction.

[Myles C. Maxfield]

CSSParserFastPaths::isKeywordPropertyID has commented lines:

    // FIXME-NEWPARSER: Treat the following properties as keyword properties:
    // case CSSPropertyBackgroundRepeatX:
    // case CSSPropertyBackgroundRepeatY:

Uncommenting these causes the example to render as expected.

[Myles C. Maxfield]

dhyatt says this is just an oversight

[Myles C. Maxfield]

Created attachment 298918 [details]
WIP

[Simon Fraser (smfr)]

Comment on attachment 298918 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=298918&action=review

> Source/WTF/wtf/Platform.h:1217
> -#define HAVE_TOUCH_BAR 1
> +#define HAVE_TOUCH_BAR 0

Unrelated.

[Myles C. Maxfield]

Created attachment 299082 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 299082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299082&action=review

> LayoutTests/fast/backgrounds/background-repeat-x-y.html:16
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-x: repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-x: no-repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-y: repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-y: no-repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-x: no-repeat; background-repeat-y: no-repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat: repeat-x; background-repeat-x: no-repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat: repeat-y; background-repeat-y: no-repeat; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-x: no-repeat; background-repeat: repeat-x; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-y: no-repeat; background-repeat: repeat-y; border: 1px solid black;"></div>
> +<div style="display: inline-block; width: 200px; height: 200px; background-image: url('resources/map.jpg'); background-position: top left; background-repeat-x: garbage; border: 1px solid black;"></div>

I think you need to make these smaller to fix 800x600.

[Myles C. Maxfield]

Created attachment 299085 [details]
Patch for committing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 299085 [details]:

media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html bug 167148 (author: [e-mail])
fast/hidpi/video-controls-in-hidpi.html bug 112940 (authors: [e-mail], [e-mail], [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 299085 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 299085 [details]
Patch for committing

Rejecting attachment 299085 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Full output: http://webkit-queues.webkit.org/results/2906613

[WebKit Commit Bot]

Created attachment 299094 [details]
Archive of layout-test-results from webkit-cq-01 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 299085 [details]
Patch for committing

Attachment 299085 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2906808

New failing tests:
fast/hidpi/video-controls-in-hidpi.html

[Build Bot]

Created attachment 299104 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Committed r210882: <http://trac.webkit.org/changeset/210882>

[Simon Fraser (smfr)]

Since we shipped with this (I think?) maybe we should revert this change.

I would like to know when it regressed.

Discussion in https://github.com/w3c/csswg-drafts/issues/116

[Simon Fraser (smfr)]

It turns out we never exposed those properties to the web. Undoing this change via bug 167223.