Bug 166992 – Web Inspector: add "Persist Logs on Navigation" to settings screen

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Requested by People.

[Radar WebKit Bug Importer]

<rdar://problem/30002041>

[Devin Rousso]

Created attachment 298796 [details]
Patch

[Devin Rousso]

Created attachment 298797 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 298796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298796&action=review

Code changes look good. I think we should improve the wording though.

How about:

Console:  [  ] Clear when main frame navigates

That makes it simple to add other console options later, like max # of messages. It's also agnostic to whether evaluations or messages get cleared (I think it's both)

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-377
> -        let clearLogOnReloadUIString = WebInspector.logManager.clearLogOnNavigateSetting.value ? WebInspector.UIString("Keep Log on Navigation") : WebInspector.UIString("Clear Log on Navigation");

I think we should remove the menu item from here. Because it's a setting and not a command (like Copy, Share, etc) it's not something that belongs in a shortcut menu.

[Nikita Vasilyev]

(In reply to comment #4)
> Comment on attachment 298796 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298796&action=review
> 
> Code changes look good. I think we should improve the wording though.
> 
> How about:
> 
> Console:  [  ] Clear when main frame navigates

How about "Clear when page navigates"? I don't think web developers use the term "main frame" very often.

Chrome uses:
[x] Preserve log
Tooltip text: "Do no clear log on page reload / navigation"

[Devin Rousso]

Created attachment 298844 [details]
Patch

[Blaze Burg]

Comment on attachment 298844 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 298844 [details]
Patch

Rejecting attachment 298844 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 298844, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   8975ae9..2575229  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 210787 = 8975ae94f8edbfb93c3e0296ac1096615f9e17b5
r210788 = 2575229eb1d36299298d44e46ab280e229421137
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2900576

[Devin Rousso]

Created attachment 298986 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 298986 [details]
Patch

Clearing flags on attachment: 298986

Committed r210793: <http://trac.webkit.org/changeset/210793>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.