NEW 166981
DumpRenderTree's credentials should support Latin-1 encoding 
https://bugs.webkit.org/show_bug.cgi?id=166981
Summary DumpRenderTree's credentials should support Latin-1 encoding
John Wilander
Reported 2017-01-12 12:49:28 PST
DumpRenderTree's setAuthenticationUsernameCallback() and setAuthenticationPasswordCallback() always convert incoming strings to UTF-8 through JSStringGetUTF8CString(). The credentials are then stored in standard strings (std::string). This cripples non-ASCII characters in Basic Authentication to the point where they are not sent in the challenge response, creating an infinite HTTP 401 loop. After the first failed attempt, challenge.previousFailureCount() in ResourceHandle::tryHandlePasswordBasedAuthentication() returns an unsigned larger than zero and ResourceHandle::tryHandlePasswordBasedAuthentication() will no longer look for credentials in the credential storage.
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.