Bug 166975 - OneDrive application crashes upon launch
Summary: OneDrive application crashes upon launch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-12 09:38 PST by youenn fablet
Modified: 2017-01-14 22:40 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2017-01-12 09:44 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-01-12 09:38:20 PST 
See radar 29910273.
SubresourceLoader::willSendRequestInternal is calling ResourceLoader::willSendRequestInternal.
App delegate code may cancel the load which will make m_resource null.
Comment 1 youenn fablet 2017-01-12 09:44:24 PST 
Created attachment 298692 [details]
Patch
Comment 2 youenn fablet 2017-01-12 12:50:42 PST 
Any idea how to add a test for it?
Ideally, we would need to have some delegate code cancelling the redirect load.
Maybe we can simulate this code path using content extension blockers?
Comment 3 Brady Eidson 2017-01-12 13:01:45 PST 
Comment on attachment 298692 [details]
Patch

Code change looks fine.

I do think it's worth following up all leads on trying to get a test for this.
Comment 4 WebKit Commit Bot 2017-01-12 13:27:53 PST 
Comment on attachment 298692 [details]
Patch

Clearing flags on attachment: 298692

Committed r210679: <http://trac.webkit.org/changeset/210679>
Comment 5 WebKit Commit Bot 2017-01-12 13:27:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2017-01-14 22:40:30 PST 
Comment on attachment 298692 [details]
Patch

Can we make a test that covers this?