Bug 166970 - [SOUP] Do not use the legacy session ID in WebFrameNetworkingContext::storageSession()
Summary: [SOUP] Do not use the legacy session ID in WebFrameNetworkingContext::storage...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Soup
Depends on:
Blocks:
 
Reported: 2017-01-12 05:35 PST by Carlos Garcia Campos
Modified: 2017-01-13 00:18 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2017-01-12 05:37 PST, Carlos Garcia Campos 		svillar: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (573.91 KB, application/zip)
2017-01-12 07:49 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-01-12 05:35:27 PST 
We should get the actual session like we do in the network process.
Comment 1 Carlos Garcia Campos 2017-01-12 05:37:20 PST 
Created attachment 298673 [details]
Patch
Comment 2 Sergio Villar Senin 2017-01-12 06:27:28 PST 
Comment on attachment 298673 [details]
Patch

sgtm provided the mac failures are unrelated.

BTW isn't this testable? Wasn't it causing any issues?
Comment 3 Carlos Garcia Campos 2017-01-12 06:34:27 PST 
(In reply to comment #2)
> Comment on attachment 298673 [details]
> Patch
> 
> sgtm provided the mac failures are unrelated.
> 
> BTW isn't this testable? Wasn't it causing any issues?

This is only used for the very few loads that still happen in the web process, and affects the private browsing mode that we don't test AFAIK.
Comment 4 Build Bot 2017-01-12 07:49:55 PST 
Comment on attachment 298673 [details]
Patch

Attachment 298673 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2877587

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-01-12 07:49:59 PST 
Created attachment 298681 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Carlos Garcia Campos 2017-01-13 00:18:31 PST 
Committed r210728: <http://trac.webkit.org/changeset/210728>