Bug 166964 – Hide the UI to trigger an A/B testing when there are no triggerables

• Status: RESOLVED
• Resolution: FIXED
• Component: Perf Dashboard

[Ryosuke Niwa]

When there are no build triggerable configured for a test, platform pair,
hide the UI to trigger A/B testing instead of showing it and then failing to create one later.

[Ryosuke Niwa]

Created attachment 298660 [details]
Fixes the bug

[Yusuke Suzuki]

Comment on attachment 298660 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=298660&action=review

r=me

> Websites/perf.webkit.org/public/v3/models/triggerable.js:13
> +            const testId = config[0];
> +            const platformId = config[1];

How about `const [testId, platformId] = config;`?

[Build Bot]

Comment on attachment 298660 [details]
Fixes the bug

Attachment 298660 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2875489

New failing tests:
fast/mediastream/MediaStream-video-element-track-stop.html

[Build Bot]

Created attachment 298663 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Ryosuke Niwa]

Thanks for the review.

(In reply to comment #2)
> Comment on attachment 298660 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298660&action=review
> 
> r=me
> 
> > Websites/perf.webkit.org/public/v3/models/triggerable.js:13
> > +            const testId = config[0];
> > +            const platformId = config[1];
> 
> How about `const [testId, platformId] = config;`?

Neat! Fixed.

[Ryosuke Niwa]

Committed r210626: <http://trac.webkit.org/changeset/210626>