Bug 166950 – Report post-page load CPU usage using diagnostic logging

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Report post-page load CPU usage using diagnostic logging.

[Chris Dumez]

Created attachment 298634 [details]
WIP Patch

[Chris Dumez]

<rdar://problem/29964139>

[Chris Dumez]

Created attachment 298690 [details]
WIP Patch

[Chris Dumez]

Created attachment 298695 [details]
Patch

[Build Bot]

Comment on attachment 298695 [details]
Patch

Attachment 298695 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2878389

New failing tests:
fast/mediastream/MediaStream-video-element-track-stop.html

[Build Bot]

Created attachment 298705 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Keith Rollin]

There might be a problem with the Timer if the user navigates away from the page before it triggers, and the next page takes a long time to load such that we now exceed the trigger time.

[Chris Dumez]

Created attachment 298725 [details]
Patch

[Chris Dumez]

(In reply to comment #7)
> There might be a problem with the Timer if the user navigates away from the
> page before it triggers, and the next page takes a long time to load such
> that we now exceed the trigger time.

Good catch, I now stop the timer on navigating away.

[Alex Christensen]

Comment on attachment 298725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298725&action=review

> Source/WebCore/loader/FrameLoader.cpp:997
> +            page->didStartLoad();

didStartProvisionalLoad?

[Chris Dumez]

Created attachment 298763 [details]
Patch

[Chris Dumez]

(In reply to comment #10)
> Comment on attachment 298725 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298725&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:997
> > +            page->didStartLoad();
> 
> didStartProvisionalLoad?

Done. Thanks for the review.

[Chris Dumez]

Comment on attachment 298763 [details]
Patch

Clearing flags on attachment: 298763

Committed r210733: <http://trac.webkit.org/changeset/210733>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #13)
> Comment on attachment 298763 [details]
> Patch
> 
> Clearing flags on attachment: 298763
> 
> Committed r210733: <http://trac.webkit.org/changeset/210733>

It broke the Apple Mac cmake build.
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/11255