Bug 166948 - check-webkit-style does not work with moved files and svn 1.9
Summary: check-webkit-style does not work with moved files and svn 1.9
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-11 16:17 PST by Jonathan Bedard
Modified: 2017-01-18 10:09 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-01-11 16:17:32 PST 
When check-webkit-style is run with moved files in svn 1.9, errors are thrown in Tools/Scripts/webkitpy/common/checkout/diff_parser.py due to an unexpected diff format.
Comment 1 Radar WebKit Bug Importer 2017-01-11 16:18:45 PST 
<rdar://problem/29979693>
Comment 2 Jonathan Bedard 2017-01-18 10:09:05 PST 
A note here, while this title is accurate, the original description of this issue is not.  check-webkit-style outputs a number of unneeded lines when files are moved, but these unneeded lines do not cause errors.  Bug 167164 was the bug which was causing the errors due to an unexpected diff format.