Bug 166943 - Web Inspector: Network Tab's "Clear Network Items" button should have keyboard shortcuts
Summary: Web Inspector: Network Tab's "Clear Network Items" button should have keyboar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-11 15:33 PST by BJ Burg
Modified: 2017-01-19 10:32 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.45 KB, patch)
2017-01-18 10:34 PST, Devin Rousso
timothy: review+
Details | Formatted Diff | Diff
Patch (10.38 KB, patch)
2017-01-19 09:48 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-11 15:33:55 PST
Let's use the ones Timeline tab has.
Comment 1 Radar WebKit Bug Importer 2017-01-11 15:34:23 PST
<rdar://problem/29978622>
Comment 2 Devin Rousso 2017-01-11 18:14:17 PST
(In reply to comment #0)
> Let's use the ones Timeline tab has.

...does it have a keyboard shortcut?  If so, we should add it to the tooltip on the Trash icon.
Comment 3 BJ Burg 2017-01-12 10:08:58 PST
(In reply to comment #2)
> (In reply to comment #0)
> > Let's use the ones Timeline tab has.
> 
> ...does it have a keyboard shortcut?  If so, we should add it to the tooltip
> on the Trash icon.

Oops, I was misremembering. It's the Console. You'll probably need to adjust the console one to be non-global, it currently works even if Console messages are not visible.
Comment 4 Devin Rousso 2017-01-18 10:34:15 PST
Created attachment 299155 [details]
Patch
Comment 5 Timothy Hatcher 2017-01-18 20:49:30 PST
Comment on attachment 299155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299155&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:2027
> +        return;

Perhaps this should still clear the console globally if the focused view does not handle it. I know folks (me included) that clear the console from other tabs just to reset the dashboard counters.
Comment 6 Devin Rousso 2017-01-19 09:48:53 PST
Created attachment 299247 [details]
Patch
Comment 7 WebKit Commit Bot 2017-01-19 10:32:20 PST
Comment on attachment 299247 [details]
Patch

Clearing flags on attachment: 299247

Committed r210930: <http://trac.webkit.org/changeset/210930>
Comment 8 WebKit Commit Bot 2017-01-19 10:32:23 PST
All reviewed patches have been landed.  Closing bug.