RESOLVED FIXED 166934
Web Inspector: color, gradient, cubic-bezier, spring editors should be dismissable using ESC 
https://bugs.webkit.org/show_bug.cgi?id=166934
Summary Web Inspector: color, gradient, cubic-bezier, spring editors should be dismis...
Blaze Burg
Reported 2017-01-11 10:50:23 PST
There is no straightforward way to dismiss these editors with the keyboard. This is annoying for workflow reasons and a blocker for making these accessible via FKA (full keyboard access). ESC is currently handled by the split console shortcut.
Attachments
Patch (4.39 KB, patch)
2017-01-11 15:19 PST, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2017-01-11 17:07 PST, Devin Rousso 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (4.19 KB, patch)
2017-01-11 17:32 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-11 11:19:37 PST
<rdar://problem/29972995>
Devin Rousso
Comment 2 2017-01-11 15:19:26 PST
Created attachment 298618 [details] Patch
Blaze Burg
Comment 3 2017-01-11 16:19:43 PST
Comment on attachment 298618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298618&action=review r=me, please fix typo > Source/WebInspectorUI/ChangeLog:13 > + Adds a keydown listener while visible for the Escape key that dismisses the popver. Nit: popover
Devin Rousso
Comment 4 2017-01-11 17:07:51 PST
Created attachment 298635 [details] Patch
WebKit Commit Bot
Comment 5 2017-01-11 17:09:43 PST
Comment on attachment 298635 [details] Patch Rejecting attachment 298635 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 298635, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2873673
Devin Rousso
Comment 6 2017-01-11 17:32:36 PST
Created attachment 298642 [details] Patch Whoops. Forgot r+ in ChangeLog :P
WebKit Commit Bot
Comment 7 2017-01-11 18:09:43 PST
Comment on attachment 298642 [details] Patch Clearing flags on attachment: 298642 Committed r210615: <http://trac.webkit.org/changeset/210615>
WebKit Commit Bot
Comment 8 2017-01-11 18:09:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.