I didn't even know we had this editor! Here are some polish things that stuck out about the layout, which make it look like a prototype: - The labels are center-aligned. I think they should be to the left of the component sliders (in LTR) - The sliders have no tracks. It makes it weird, I don't know the extent of where they go. - The sliders have no labels. You can enter a value much larger than the slider's max value (say, 1000), and it looks the same as if the slider was at 100. (Maybe it should rescale if a big value is entered manually.) - The text fields are too big (~8 characters), especially considering the default slider range is [0,100]. - Not really about the layout, but it's often the case that the popover covers up the property declaration, so I can't see how the values are used in the syntax (spring syntax seems to differ from every other timing function).
<rdar://problem/29972516>
(In reply to comment #0) > I didn't even know we had this editor! (☞ﾟヮﾟ)☞ > - The sliders have no tracks. It makes it weird, I don't know the extent of > where they go. I think this is a regression, because the style was added in <https://webkit.org/b/148120> and I distinctly remember seeing it work. It doesn't even show up in the styles sidebar anymore. > - The sliders have no labels. You can enter a value much larger than the > slider's max value (say, 1000), and it looks the same as if the slider was > at 100. (Maybe it should rescale if a big value is entered manually.) Would it make sense to have the slider be a relative slider, meaning one that always resets to the center and just allows for faster value changing? Do you think we even need to keep the slider? > - Not really about the layout, but it's often the case that the popover > covers up the property declaration, so I can't see how the values are used > in the syntax (spring syntax seems to differ from every other timing > function). I agree. This happens a lot. Not sure how to fix it though.
Created attachment 298612 [details] [WIP] Patch
Created attachment 298614 [details] Patch
Created attachment 298615 [details] [Image] After Patch is applied
Created attachment 298620 [details] Patch
Comment on attachment 298620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298620&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SpringEditor.css:105 > + width: calc(75% - 10px); Cool. Might want to use a var() here since it corresponds to the right-margin. > Source/WebInspectorUI/UserInterface/Views/SpringEditor.js:194 > + WebInspector.reportInternalError("Input event fired for unrecognized element"); Nice!
Created attachment 298641 [details] Patch
Comment on attachment 298641 [details] Patch Clearing flags on attachment: 298641 Committed r210618: <http://trac.webkit.org/changeset/210618>
All reviewed patches have been landed. Closing bug.