Bug 166928 - Web Inspector: cubic-bezier editor behaves poorly for invalid inputs in component fields
Summary: Web Inspector: cubic-bezier editor behaves poorly for invalid inputs in compo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-11 10:19 PST by BJ Burg
Modified: 2017-01-12 12:23 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.59 KB, patch)
2017-01-11 10:56 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (537.32 KB, application/zip)
2017-01-11 20:21 PST, Build Bot
no flags Details
Patch (3.72 KB, patch)
2017-01-11 21:29 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-11 10:19:01 PST
Entering anything that's not a non-negative number turns the text field value into NaN and puts NaN into the property declaration in the sidebar.

In this case, I would expect it to not edit the property declaration in the rule. It should highlight the bad value in red and explain why it's invalid (perhaps with a popover when hovered/selected), allowing the user to fix it themselves or click a button to revert.
Comment 1 Radar WebKit Bug Importer 2017-01-11 10:19:20 PST
<rdar://problem/29971394>
Comment 2 Devin Rousso 2017-01-11 10:56:15 PST
Created attachment 298602 [details]
Patch
Comment 3 Devin Rousso 2017-01-11 10:58:08 PST
(In reply to comment #0)
> It should highlight the bad value in red and explain why it's invalid
> (perhaps with a popover when hovered/selected), allowing the user to fix it
> themselves or click a button to revert.

I think that adding this really would be a bit too much clutter (popovers inside popovers).  I think that just having the input show a number "stepper" (not sure what to call the up/down arrow for <input type="number"> elements) implies that the value should be a number.
Comment 4 Build Bot 2017-01-11 20:21:05 PST
Comment on attachment 298602 [details]
Patch

Attachment 298602 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2874902

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-01-11 20:21:09 PST
Created attachment 298655 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Devin Rousso 2017-01-11 21:29:41 PST
Created attachment 298658 [details]
Patch
Comment 7 BJ Burg 2017-01-12 09:50:29 PST
Comment on attachment 298658 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2017-01-12 12:23:03 PST
Comment on attachment 298658 [details]
Patch

Clearing flags on attachment: 298658

Committed r210674: <http://trac.webkit.org/changeset/210674>
Comment 9 WebKit Commit Bot 2017-01-12 12:23:08 PST
All reviewed patches have been landed.  Closing bug.