Bug 166918 - [iOS][WK2] KeyboardEvent.key always returns an empty string
Summary: [iOS][WK2] KeyboardEvent.key always returns an empty string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-10 19:50 PST by Chris Dumez
Modified: 2017-01-11 07:46 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.68 KB, patch)
2017-01-10 20:38 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (8.00 KB, patch)
2017-01-10 20:54 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-10 19:50:59 PST
Make sure KeyboardEvent.key is properly initialized on iOS WK2.
Comment 1 Chris Dumez 2017-01-10 19:51:14 PST
<rdar://problem/29861147>
Comment 2 Chris Dumez 2017-01-10 20:38:52 PST
Created attachment 298550 [details]
Patch
Comment 3 Chris Dumez 2017-01-10 20:43:09 PST
Comment on attachment 298550 [details]
Patch

Will fix EFL.
Comment 4 Wenson Hsieh 2017-01-10 20:46:58 PST
Comment on attachment 298550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298550&action=review

> LayoutTests/fast/events/ios/keyboard-event-key-attribute.html:23
> +function getInputFocusUIScript()

Nit - I would pass x, y as arguments to the function here.

> LayoutTests/fast/events/ios/keyboard-event-key-attribute.html:49
> +    window.setTimeout(function() {

Instead of using a timeout here, I think you use didShowKeyboardCallback. See fast/events/ios/keyboard-should-not-trigger-resize.html for an example.
Comment 5 Chris Dumez 2017-01-10 20:54:06 PST
Created attachment 298552 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-11 07:46:38 PST
Comment on attachment 298552 [details]
Patch

Clearing flags on attachment: 298552

Committed r210586: <http://trac.webkit.org/changeset/210586>
Comment 7 WebKit Commit Bot 2017-01-11 07:46:44 PST
All reviewed patches have been landed.  Closing bug.