Bug 166908 – Web Inspector: Network tab: provide a way to preserve log on navigation

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Currently, network tab gets cleared on main resource navigation.

Preserving log on navigation is very helpful when debugging redirects.

[Radar WebKit Bug Importer]

<rdar://problem/29958216>

[Devin Rousso]

Created attachment 300148 [details]
Patch

[Nikita Vasilyev]

This looks like a good first step.

When navigating from page A to page B, there's no easy way to see which resources loaded on which page. It would be nice to have a horizontal divider in the data grid between previous and current page loads. The dividers may look similar to what we use in the console https://bugs.webkit.org/show_bug.cgi?id=161938#c3.

[Devin Rousso]

(In reply to comment #3)
> This looks like a good first step.
> 
> When navigating from page A to page B, there's no easy way to see which
> resources loaded on which page. It would be nice to have a horizontal
> divider in the data grid between previous and current page loads. The
> dividers may look similar to what we use in the console
> https://bugs.webkit.org/show_bug.cgi?id=161938#c3.

I definitely agree that this would be nice, but I'm trying to piece through the WI.TimelineDataGrid code right now and it is very dense.  I'm not sure if I am the best person to attempt doing this.

From what I can see so far, it seems like there would need to be some sort of "TitleDataGridNode" that spans multiple columns (via the `colspan` attribute maybe), but either it would also have to implement all of the additional WI.TimelineDataGridNode functions or some logic would need to be added to WI.TimelineDataGrid to ignore instances of "TimelineDataGridNode" when calling certain functions.  Additionally, something would have to be done in WI.NetworkSidebarPanel, but that is just a tree, so it should be a lot easier.

Any tips/pointers would be greatly appreciated.

[Matt Baker]

(In reply to comment #4)
> (In reply to comment #3)
> > This looks like a good first step.
> > 
> > When navigating from page A to page B, there's no easy way to see which
> > resources loaded on which page. It would be nice to have a horizontal
> > divider in the data grid between previous and current page loads. The
> > dividers may look similar to what we use in the console
> > https://bugs.webkit.org/show_bug.cgi?id=161938#c3.
> 
> I definitely agree that this would be nice, but I'm trying to piece through
> the WI.TimelineDataGrid code right now and it is very dense.  I'm not sure
> if I am the best person to attempt doing this.
> 
> From what I can see so far, it seems like there would need to be some sort
> of "TitleDataGridNode" that spans multiple columns (via the `colspan`
> attribute maybe), but either it would also have to implement all of the
> additional WI.TimelineDataGridNode functions or some logic would need to be
> added to WI.TimelineDataGrid to ignore instances of "TimelineDataGridNode"
> when calling certain functions.  Additionally, something would have to be
> done in WI.NetworkSidebarPanel, but that is just a tree, so it should be a
> lot easier.
> 
> Any tips/pointers would be greatly appreciated.

I think an alternative approach would be preferable. A visual divider in the grid will be awkward to implement, as you've already mentioned. Would it be enough to just style all or part of the grid node text differently?

[Matt Baker]

Created attachment 300244 [details]
[Image] Dimmed network rows

Quick photoshop mockup

[Devin Rousso]

Created attachment 300250 [details]
Patch

[Devin Rousso]

Created attachment 300251 [details]
[Image] After Patch is applied

[Matt Baker]

(In reply to comment #8)
> Created attachment 300251 [details]
> [Image] After Patch is applied

I think I like it. Styling a "previous" item's icon with normal saturation when selected is a nice touch.

[Matt Baker]

The graph node should have normal saturation when the row is selected. It will be very hard to distinguish between desaturated bar segments when more timing data is shown.

[Devin Rousso]

(In reply to comment #10)
> The graph node should have normal saturation when the row is selected. It
> will be very hard to distinguish between desaturated bar segments when more
> timing data is shown.

I just realized that it's hard to see in the screenshot, but it actually does this already :D

[Matt Baker]

(In reply to comment #11)
> (In reply to comment #10)
> > The graph node should have normal saturation when the row is selected. It
> > will be very hard to distinguish between desaturated bar segments when more
> > timing data is shown.
> 
> I just realized that it's hard to see in the screenshot, but it actually
> does this already :D

Hah, I thought that might be the case.

[Matt Baker]

Comment on attachment 300250 [details]
Patch

We may want to revisit the row styles eventually, and dim icons in preserved rows even when selected. if the selected row is the last (or only) preserved row it's visually indistinguishable from the first non-preserved row.

For now this helps to distinguish preserved rows.

[WebKit Commit Bot]

Comment on attachment 300250 [details]
Patch

Clearing flags on attachment: 300250

Committed r211451: <http://trac.webkit.org/changeset/211451>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Blaze Burg]

*** Bug 114232 has been marked as a duplicate of this bug. ***