Bug 166904 - Missing logging in IconLoader::startLoading
Summary: Missing logging in IconLoader::startLoading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-10 14:01 PST by Keith Rollin
Modified: 2017-01-10 15:10 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2017-01-10 14:03 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2017-01-10 14:01:01 PST 
The LOG_ERROR in startLoading references 'resourceRequest', which has been WTF::Moved as part of a preceding function call. As such, the logging statement doesn't print out a possibly useful URL.
Comment 1 Keith Rollin 2017-01-10 14:03:53 PST 
Created attachment 298511 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-10 15:10:47 PST 
Comment on attachment 298511 [details]
Patch

Clearing flags on attachment: 298511

Committed r210562: <http://trac.webkit.org/changeset/210562>
Comment 3 WebKit Commit Bot 2017-01-10 15:10:53 PST 
All reviewed patches have been landed.  Closing bug.