Bug 166902 – Keyboard accessory bar can appear on top of full-screen video

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Keyboard accessory bar can appear on top of full-screen video

[Tim Horton]

Created attachment 298500 [details]
Patch

[Sam Weinig]

Test?

[Tim Horton]

Of full-screen window level? Maybe with Jer's new test app?

[Tim Horton]

(In reply to comment #3)
> Of full-screen window level? Maybe with Jer's new test app?

Not sure it's super valuable, though, I will just end up testing that an integer that I set is still the value that I set it to :|

Also, the UI test app doesn't seem super fleshed out yet, so it should probably be a layout test (it does seem like we can go full-screen in a layout test) with some UISC glue to check the window level?

[Tim Horton]

(In reply to comment #2)
> Test?

I think not, for now. WebKitTestRunner still doesn't seem to have enough UIKit infrastructure (it's still not a UIApplication) set up to make full-screen actually work (though I just spent far too long trying). I will try again with MobileMiniBrowser, but it's not very scalable (currently have to add new UI for each test).

[Simon Fraser (smfr)]

(In reply to comment #5)
> (In reply to comment #2)
> > Test?
> 
> I think not, for now. WebKitTestRunner still doesn't seem to have enough
> UIKit infrastructure (it's still not a UIApplication)

iOS uses WebKitTestRunnerApp.app, which is a UIApplication with a root view controller.

[Tim Horton]

Hmm, odd. I was getting all manner of bizarre logging to the contrary from UIWindow, but maybe I was doing something wrong.

[WebKit Commit Bot]

Comment on attachment 298500 [details]
Patch

Clearing flags on attachment: 298500

Committed r210727: <http://trac.webkit.org/changeset/210727>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.