Bug 166897 – Do dot allow selection of editable content when not editing

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Enrica Casucci]

Long press/force press should not create a selection in editable content if we are not already editing.
We want to allow the selection in editable content (input elements, text areas or content editable) only after the user has focused the field and keyboard is on screen.

rdar://problem/29388806

[Enrica Casucci]

Created attachment 298491 [details]
Patch

[Tim Horton]

Comment on attachment 298491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298491&action=review

> Source/WebKit2/ChangeLog:3
> +        Do dot allow selection of editable content when not editing.

s/dot/not/?

> Source/WebKit2/ChangeLog:11
> +        When retrieving the position information, we should not consider
> +        as candidates for selection editable elements, since this is only
> +        used for non editable selections.

Seems like this should be quite easy to test with some of the stuff that Megan has been hooking up, no?

[Enrica Casucci]

(In reply to comment #2)
> Comment on attachment 298491 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298491&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        Do dot allow selection of editable content when not editing.
> 
> s/dot/not/?
> 
> > Source/WebKit2/ChangeLog:11
> > +        When retrieving the position information, we should not consider
> > +        as candidates for selection editable elements, since this is only
> > +        used for non editable selections.
> 
> Seems like this should be quite easy to test with some of the stuff that
> Megan has been hooking up, no?

Yes, I'll write a test.

[Enrica Casucci]

Created attachment 298731 [details]
Patch2

Patch with test.

[Tim Horton]

Comment on attachment 298731 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=298731&action=review

> LayoutTests/fast/events/touch/ios/long-press-on-editable.html:21
> +        function getTapScript()

Nothing ever calls this function?

> LayoutTests/fast/events/touch/ios/long-press-on-editable.html:28
> +             })();`

This line is indented wrong, I think. One space too many?

[Enrica Casucci]

(In reply to comment #5)
> Comment on attachment 298731 [details]
> Patch2
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298731&action=review
> 
> > LayoutTests/fast/events/touch/ios/long-press-on-editable.html:21
> > +        function getTapScript()
> 
> Nothing ever calls this function?
> 
> > LayoutTests/fast/events/touch/ios/long-press-on-editable.html:28
> > +             })();`
> 
> This line is indented wrong, I think. One space too many?

Copy paste :-( Will fix it.

[Enrica Casucci]

Committed revision 210687.