Bug 166894 - Make Event.initEvent()'s first parameter mandatory
Summary: Make Event.initEvent()'s first parameter mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2017-01-10 10:42 PST by Chris Dumez
Modified: 2017-01-10 14:00 PST (History)
8 users (show)

See Also:


Attachments
Patch (7.77 KB, patch)
2017-01-10 10:44 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-10 10:42:11 PST
Make Event.initEvent()'s first parameter mandatory.
Comment 1 Chris Dumez 2017-01-10 10:44:50 PST
Created attachment 298479 [details]
Patch
Comment 2 Alex Christensen 2017-01-10 13:44:01 PST
Comment on attachment 298479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298479&action=review

> Source/WebCore/ChangeLog:13
> +        the specification. However, having the first parameter optional
> +        makes little sense as it would set the event's type to the string
> +        "undefined".

Also, all the content we found that was broken by making all three mandatory had one parameter indicating the type.
Comment 3 WebKit Commit Bot 2017-01-10 14:00:18 PST
Comment on attachment 298479 [details]
Patch

Clearing flags on attachment: 298479

Committed r210559: <http://trac.webkit.org/changeset/210559>
Comment 4 WebKit Commit Bot 2017-01-10 14:00:22 PST
All reviewed patches have been landed.  Closing bug.