Bug 166892 - Web Inspector: fix UIString for Print Styles button
Summary: Web Inspector: fix UIString for Print Styles button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-10 10:18 PST by Brian Burg
Modified: 2017-01-11 12:31 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2017-01-10 17:35 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-01-10 10:18:14 PST
Per ASG, this should say 'turn on/off' instead of enable/disable.
Comment 1 Radar WebKit Bug Importer 2017-01-10 10:18:30 PST
<rdar://problem/29950216>
Comment 2 Brian Burg 2017-01-10 10:59:36 PST
Or even better, it could say "Force Print Media Styles" / "Use Default Media Styles". In the documentation we would have a better explanation that @media is being overridden to 'print' when this is on.
Comment 3 Joseph Pecoraro 2017-01-10 11:11:39 PST
(In reply to comment #2)
> Or even better, it could say "Force Print Media Styles" / "Use Default Media Styles".

I like that!
Comment 4 Devin Rousso 2017-01-10 17:35:44 PST
Created attachment 298536 [details]
Patch
Comment 5 Brian Burg 2017-01-11 09:59:51 PST
Comment on attachment 298536 [details]
Patch

rs=me, Thanks Devin!
Comment 6 Joseph Pecoraro 2017-01-11 11:10:04 PST
Comment on attachment 298536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298536&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814
> +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles";

Should the "s" in "Styles" be capitalized for these?
Comment 7 Brian Burg 2017-01-11 11:31:02 PST
(In reply to comment #6)
> Comment on attachment 298536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298536&action=review
> 
> > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814
> > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles";
> 
> Should the "s" in "Styles" be capitalized for these?

It's unclear whether this string should be title case. This seems more like a button label than a description. We are inconsistent about this in many places.
Comment 8 Brian Burg 2017-01-11 11:35:24 PST
(In reply to comment #7)
> (In reply to comment #6)
> > Comment on attachment 298536 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=298536&action=review
> > 
> > > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814
> > > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles";
> > 
> > Should the "s" in "Styles" be capitalized for these?
> 
> It's unclear whether this string should be title case. This seems more like
> a button label than a description. We are inconsistent about this in many
> places.

More context: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW4

This seems to be a help tag for button. Since the AX title would be categorized like Push Button, I think this is still the correct capitalization.
Comment 9 WebKit Commit Bot 2017-01-11 12:31:52 PST
Comment on attachment 298536 [details]
Patch

Clearing flags on attachment: 298536

Committed r210594: <http://trac.webkit.org/changeset/210594>
Comment 10 WebKit Commit Bot 2017-01-11 12:31:56 PST
All reviewed patches have been landed.  Closing bug.