Bug 166892 – Web Inspector: fix UIString for Print Styles button

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Per ASG, this should say 'turn on/off' instead of enable/disable.

[Radar WebKit Bug Importer]

<rdar://problem/29950216>

[Blaze Burg]

Or even better, it could say "Force Print Media Styles" / "Use Default Media Styles". In the documentation we would have a better explanation that @media is being overridden to 'print' when this is on.

[Joseph Pecoraro]

(In reply to comment #2)
> Or even better, it could say "Force Print Media Styles" / "Use Default Media Styles".

I like that!

[Devin Rousso]

Created attachment 298536 [details]
Patch

[Blaze Burg]

Comment on attachment 298536 [details]
Patch

rs=me, Thanks Devin!

[Joseph Pecoraro]

Comment on attachment 298536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298536&action=review

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814
> +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles";

Should the "s" in "Styles" be capitalized for these?

[Blaze Burg]

(In reply to comment #6)
> Comment on attachment 298536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298536&action=review
> 
> > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814
> > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles";
> 
> Should the "s" in "Styles" be capitalized for these?

It's unclear whether this string should be title case. This seems more like a button label than a description. We are inconsistent about this in many places.

[Blaze Burg]

(In reply to comment #7)
> (In reply to comment #6)
> > Comment on attachment 298536 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=298536&action=review
> > 
> > > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:814
> > > +localizedStrings["Use Default Media Styles"] = "Use Default Media Styles";
> > 
> > Should the "s" in "Styles" be capitalized for these?
> 
> It's unclear whether this string should be title case. This seems more like
> a button label than a description. We are inconsistent about this in many
> places.

More context: https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW4

This seems to be a help tag for button. Since the AX title would be categorized like Push Button, I think this is still the correct capitalization.

[WebKit Commit Bot]

Comment on attachment 298536 [details]
Patch

Clearing flags on attachment: 298536

Committed r210594: <http://trac.webkit.org/changeset/210594>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.