Bug 166881 - :active and :hover states may not be updated across slots
Summary: :active and :hover states may not be updated across slots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-10 00:48 PST by Ryosuke Niwa
Modified: 2017-01-10 15:35 PST (History)
13 users (show)

See Also:

Attachments
Fixes the bug (9.92 KB, patch)
2017-01-10 01:08 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (973.61 KB, application/zip)
2017-01-10 02:19 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.62 MB, application/zip)
2017-01-10 02:36 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.02 MB, application/zip)
2017-01-10 03:56 PST, Build Bot 		no flags Details
Fixed a bug in parentElementInComposedTree (10.05 KB, patch)
2017-01-10 12:52 PST, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-01-10 00:48:11 PST 
When using shadow roots and slots, :active and :hover states may get out of sync.
Comment 1 Radar WebKit Bug Importer 2017-01-10 00:48:53 PST 
<rdar://problem/29944582>
Comment 2 Ryosuke Niwa 2017-01-10 01:08:20 PST 
Created attachment 298450 [details]
Fixes the bug
Comment 3 Build Bot 2017-01-10 02:19:51 PST 
Comment on attachment 298450 [details]
Fixes the bug

Attachment 298450 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2863079

New failing tests:
fast/css/hover-active-drag.html
Comment 4 Build Bot 2017-01-10 02:19:56 PST 
Created attachment 298452 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-01-10 02:36:51 PST 
Comment on attachment 298450 [details]
Fixes the bug

Attachment 298450 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2863114

New failing tests:
fast/css/hover-active-drag.html
Comment 6 Build Bot 2017-01-10 02:36:56 PST 
Created attachment 298453 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-01-10 03:56:04 PST 
Comment on attachment 298450 [details]
Fixes the bug

Attachment 298450 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2863411

New failing tests:
fast/css/hover-active-drag.html
Comment 8 Build Bot 2017-01-10 03:56:10 PST 
Created attachment 298455 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Ryosuke Niwa 2017-01-10 12:52:02 PST 
Created attachment 298505 [details]
Fixed a bug in parentElementInComposedTree
Comment 10 Antti Koivisto 2017-01-10 12:56:57 PST 
Comment on attachment 298505 [details]
Fixed a bug in parentElementInComposedTree

View in context: https://bugs.webkit.org/attachment.cgi?id=298505&action=review

> Source/WebCore/ChangeLog:11
> +        and parentNode. Fixed the bug by using parentOrShadowHostElement instead since :hover and :active

I think you mean 'parentElementInComposedTree'.
Comment 11 Ryosuke Niwa 2017-01-10 15:35:54 PST 
Committed r210564: <http://trac.webkit.org/changeset/210564>