Bug 166876 - REGRESSION(r189555): ImageDocument title no longer includes the size of the image
Summary: REGRESSION(r189555): ImageDocument title no longer includes the size of the i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-09 19:56 PST by Chris Dumez
Modified: 2017-01-10 12:13 PST (History)
8 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2017-01-09 20:00 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (1.38 KB, patch)
2017-01-10 10:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-09 19:56:10 PST
ImageDocument title no longer includes the size of the image after r189555.
Comment 1 Chris Dumez 2017-01-09 19:56:32 PST
<rdar://problem/29939970>
Comment 2 Chris Dumez 2017-01-09 20:00:06 PST
Created attachment 298435 [details]
Patch
Comment 3 WebKit Commit Bot 2017-01-09 21:05:38 PST
Comment on attachment 298435 [details]
Patch

Clearing flags on attachment: 298435

Committed r210536: <http://trac.webkit.org/changeset/210536>
Comment 4 WebKit Commit Bot 2017-01-09 21:05:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2017-01-09 23:00:57 PST
Comment on attachment 298435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298435&action=review

> Source/WebCore/html/ImageDocument.cpp:220
> +    auto head = HTMLHeadElement::create(*this);
> +    rootElement->appendChild(head);

Classic case where we might want a “why” comment.
Comment 6 Chris Dumez 2017-01-10 10:52:16 PST
Reopening to attach new patch.
Comment 7 Chris Dumez 2017-01-10 10:52:19 PST
Created attachment 298482 [details]
Patch
Comment 8 WebKit Commit Bot 2017-01-10 12:13:20 PST
Comment on attachment 298482 [details]
Patch

Clearing flags on attachment: 298482

Committed r210556: <http://trac.webkit.org/changeset/210556>
Comment 9 WebKit Commit Bot 2017-01-10 12:13:26 PST
All reviewed patches have been landed.  Closing bug.