Bug 166872 – [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

After r210523: <http://trac.webkit.org/changeset/210523> we are ready to add the new release test bot for Wayland (WebKitGTK+).

This bot will run the tests under a real wayland session (using the machine native GPU -- an Intel i7-3770 GPU with Mesa and a native Weston session).

Since we would have to restart the master to make the changes effective and to avoid more restarts than needed, we seize this bug also to start passing --display-server=xorg to the GTK perf bot so we can stop using the environment variable USE_NATIVE_XDISPLAY=1 to tell the perf bot to use the driver for native X11 on the perf-test step.

[Carlos Alberto Lopez Perez]

Created attachment 298421 [details]
Patch

[Michael Catanzaro]

Comment on attachment 298421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298421&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:297
> +                      "additionalArguments": ["--display-server=xorg"],

I would go ahead and remove the FIXME you left in the previous commit now, since you're squeezing this in here anyway.

[Carlos Alberto Lopez Perez]

(In reply to comment #2)
> Comment on attachment 298421 [details]
> Patch
> 

Thanks for the review

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298421&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:297
> > +                      "additionalArguments": ["--display-server=xorg"],
> 
> I would go ahead and remove the FIXME you left in the previous commit now,
> since you're squeezing this in here anyway.

I intend to do that in an unreviewed follow-up patch after this patch lands and the master is rebooted. Otherwise I will be risking having the bot running the perf tests with xvfb in the window between [this_path_lands, master_is_rebooted]

[WebKit Commit Bot]

Comment on attachment 298421 [details]
Patch

Clearing flags on attachment: 298421

Committed r210539: <http://trac.webkit.org/changeset/210539>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Alberto Lopez Perez]

(In reply to comment #3)
> > I would go ahead and remove the FIXME you left in the previous commit now,
> > since you're squeezing this in here anyway.
> 
> I intend to do that in an unreviewed follow-up patch after this patch lands
> and the master is rebooted. Otherwise I will be risking having the bot
> running the perf tests with xvfb in the window between [this_path_lands,
> master_is_rebooted]

Committed r210547: <http://trac.webkit.org/changeset/210547>