Bug 166864 – [QuickLook] Do some cleanup in QuickLookHandle

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[QuickLook] Do some cleanup in QuickLookHandle

[Andy Estes]

Created attachment 298423 [details]
Patch

[WebKit Commit Bot]

Attachment 298423 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/ios/QuickLook.mm:284:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Comment on attachment 298423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298423&action=review

> Source/WebCore/ChangeLog:21
> +        (-[WebPreviewConverter _sendDidReceiveResponseIfNecessary]): Stoped checking for a nil

Typo:  Stoped => Stopped

> Source/WebCore/ChangeLog:24
> +        (-[WebResourceLoaderQuickLookDelegate connection:didReceiveDataArray:]): Deleted.
> +        QLPreviewConverter never calls this method.

Curious why this is never called (QuickLook.framework doesn't define the delegate itself?), but answering this is NOT a blocker to land the patch.

[Andy Estes]

(In reply to comment #3)
> Comment on attachment 298423 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298423&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        (-[WebPreviewConverter _sendDidReceiveResponseIfNecessary]): Stoped checking for a nil
> 
> Typo:  Stoped => Stopped

Oops, will fix.

> 
> > Source/WebCore/ChangeLog:24
> > +        (-[WebResourceLoaderQuickLookDelegate connection:didReceiveDataArray:]): Deleted.
> > +        QLPreviewConverter never calls this method.
> 
> Curious why this is never called (QuickLook.framework doesn't define the
> delegate itself?), but answering this is NOT a blocker to land the patch.

There is no formal protocol defined by QuickLook for the delegate to conform to. It's informally based on NSURLConnectionDelegate, but -connection:didReceiveDataArray: is not one of the methods QuickLook calls (I think we originally implemented this in QuickLook by copying one of our ResourceHandle delegates).

[WebKit Commit Bot]

Comment on attachment 298423 [details]
Patch

Clearing flags on attachment: 298423

Committed r210789: <http://trac.webkit.org/changeset/210789>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andy Estes]

Fixed the ChangeLog typo in r210791.