RESOLVED FIXED 166853
[TexMap] Use WTF::Function in TextureMapperPlatformLayerProxy 
https://bugs.webkit.org/show_bug.cgi?id=166853
Summary [TexMap] Use WTF::Function in TextureMapperPlatformLayerProxy
Zan Dobersek
Reported 2017-01-09 11:07:51 PST
[TexMap] Use WTF::Function in TextureMapperPlatformLayerProxy
Attachments
Patch (3.38 KB, patch)
2017-01-09 11:08 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-01-09 11:08:44 PST
Created attachment 298371 [details] Patch
Michael Catanzaro
Comment 2 2017-01-09 12:24:56 PST
Comment on attachment 298371 [details] Patch I know we have been making this change all over the place, but I wonder what's wrong with std::function? It's "bloat", really? There's no description in wtf/Function.h of why the class is useful, which is a shame.
Zan Dobersek
Comment 3 2017-01-10 04:19:00 PST
(In reply to comment #2) > Comment on attachment 298371 [details] > Patch > > I know we have been making this change all over the place, but I wonder > what's wrong with std::function? It's "bloat", really? There's no > description in wtf/Function.h of why the class is useful, which is a shame. std::function<> is prone to accidental copying, meaning that all the captured data (via std::bind() or lambda) is copied as well -- unless you're lucky enough to capture a non-copyable object that would throw up a compilation error if std::function<> that's capturing it was being copied.
Zan Dobersek
Comment 4 2017-01-10 04:19:20 PST
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 298371 [details] > > Patch > > > > I know we have been making this change all over the place, but I wonder > > what's wrong with std::function? It's "bloat", really? There's no > > description in wtf/Function.h of why the class is useful, which is a shame. > > std::function<> is prone to accidental copying, meaning that all the > captured data (via std::bind() or lambda) is copied as well -- unless you're > lucky enough to capture a non-copyable object that would throw up a > compilation error if std::function<> that's capturing it was being copied. ... while WTF::Function is non-copyable.
Zan Dobersek
Comment 5 2017-01-10 04:30:39 PST
Comment on attachment 298371 [details] Patch Clearing flags on attachment: 298371 Committed r210542: <http://trac.webkit.org/changeset/210542>
Zan Dobersek
Comment 6 2017-01-10 04:30:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.