Bug 166839 - macOS does not support php7 for layout tests
Summary: macOS does not support php7 for layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-09 05:21 PST by Lucas Forschler
Modified: 2017-01-09 09:50 PST (History)
5 users (show)

See Also:

Attachments
v1 patch to add php7 support for macOS. (7.55 KB, patch)
2017-01-09 05:35 PST, Lucas Forschler 		no flags Details | Formatted Diff | Diff
v2, correct style (7.52 KB, patch)
2017-01-09 05:53 PST, Lucas Forschler 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-01-09 05:21:23 PST 
Currently, the macOS port uses php5. We should plan for the future and support php7.
Comment 1 Lucas Forschler 2017-01-09 05:22:14 PST 
The debian port simply searches for a lib7php, and then uses a different apache config. It seems like extending that for macOS would be simple.
Comment 2 Lucas Forschler 2017-01-09 05:35:28 PST 
Created attachment 298347 [details]
v1 patch to add php7 support for macOS.
Comment 3 WebKit Commit Bot 2017-01-09 05:37:52 PST 
Attachment 298347 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/port/base.py:1190:  trailing whitespace  [pep8/W291] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Lucas Forschler 2017-01-09 05:53:42 PST 
Created attachment 298348 [details]
v2, correct style
Comment 5 Alexey Proskuryakov 2017-01-09 09:09:12 PST 
Comment on attachment 298348 [details]
v2, correct style

It's unfortunate that the config had to be duplicated again. I hoped that we could pass an option via command line.

Could you land this manually while doing an "svn cp" first, to preserve file history?
Comment 6 Lucas Forschler 2017-01-09 09:41:31 PST 
Committed revision 210510.
Comment 7 Lucas Forschler 2017-01-09 09:45:59 PST 
(new conf file copied over in https://trac.webkit.org/changeset/210509)