RESOLVED FIXED 166835
[WebIDL] Autogenerate named getters 
https://bugs.webkit.org/show_bug.cgi?id=166835
Summary [WebIDL] Autogenerate named getters
Sam Weinig
Reported 2017-01-08 21:40:31 PST
[WebIDL] Autogenerate named getters
Attachments
Patch (119.78 KB, patch)
2017-01-10 15:29 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (121.04 KB, patch)
2017-01-10 16:30 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (121.11 KB, patch)
2017-01-10 16:42 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (845.59 KB, application/zip)
2017-01-10 17:44 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.48 MB, application/zip)
2017-01-10 18:00 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (9.60 MB, application/zip)
2017-01-10 18:06 PST, Build Bot 		no flags
Details
Patch (118.34 KB, patch)
2017-01-11 10:03 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (116.88 KB, patch)
2017-01-11 12:24 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (119.25 KB, patch)
2017-01-11 16:52 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-01-10 15:29:17 PST
Created attachment 298515 [details] Patch
Sam Weinig
Comment 2 2017-01-10 15:29:42 PST
Comment on attachment 298515 [details] Patch For the bots to chew on.
Sam Weinig
Comment 3 2017-01-10 16:30:02 PST
Created attachment 298522 [details] Patch
Sam Weinig
Comment 4 2017-01-10 16:42:31 PST
Created attachment 298524 [details] Patch
Build Bot
Comment 5 2017-01-10 17:44:20 PST
Comment on attachment 298524 [details] Patch Attachment 298524 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2866696 New failing tests: fast/dom/collection-null-like-arguments.html imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection.html fast/dom/collection-length-should-not-be-overridden.html imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
Build Bot
Comment 6 2017-01-10 17:44:22 PST
Created attachment 298538 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 7 2017-01-10 18:00:18 PST
Comment on attachment 298524 [details] Patch Attachment 298524 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2866768 New failing tests: fast/dom/collection-null-like-arguments.html imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection.html fast/dom/collection-length-should-not-be-overridden.html imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
Build Bot
Comment 8 2017-01-10 18:00:20 PST
Created attachment 298539 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 9 2017-01-10 18:06:00 PST
Comment on attachment 298524 [details] Patch Attachment 298524 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2866784 New failing tests: fast/dom/collection-null-like-arguments.html imported/w3c/web-platform-tests/shadow-dom/leaktests/html-collection.html fast/dom/collection-length-should-not-be-overridden.html imported/w3c/web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
Build Bot
Comment 10 2017-01-10 18:06:03 PST
Created attachment 298540 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Sam Weinig
Comment 11 2017-01-11 10:03:44 PST
Created attachment 298594 [details] Patch
Sam Weinig
Comment 12 2017-01-11 12:24:18 PST
Created attachment 298606 [details] Patch
Sam Weinig
Comment 13 2017-01-11 16:52:44 PST
Created attachment 298632 [details] Patch
Sam Weinig
Comment 14 2017-01-11 23:27:50 PST
Ready for review.
Alex Christensen
Comment 15 2017-01-12 09:52:43 PST
Comment on attachment 298632 [details] Patch r=me, but you should add a bindings test for this
WebKit Commit Bot
Comment 16 2017-01-12 10:31:59 PST
Comment on attachment 298632 [details] Patch Clearing flags on attachment: 298632 Committed r210667: <http://trac.webkit.org/changeset/210667>
WebKit Commit Bot
Comment 17 2017-01-12 10:32:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.