Bug 166834 – [WebIDL] Remove most of the custom bindings for the WebGL code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Remove most of the custom bindings for the WebGL code

[Sam Weinig]

Created attachment 298324 [details]
Patch

[Sam Weinig]

Only thing left is getExtension in WebGLRenderingContextBase.idl, which, with a little refactoring, we can use the new OverrideIDLType extended attribute to vanquish.

[Sam Weinig]

Created attachment 298326 [details]
Patch

[Sam Weinig]

Created attachment 298327 [details]
Patch

[Sam Weinig]

Created attachment 298328 [details]
Patch

[Build Bot]

Comment on attachment 298328 [details]
Patch

Attachment 298328 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2856449

New failing tests:
fast/canvas/webgl/context-lost.html
webgl/1.0.2/conformance/state/gl-object-get-calls.html
fast/canvas/webgl/gl-object-get-calls.html
webgl/1.0.2/conformance/context/context-lost.html
fast/canvas/webgl/uniform-array-length-overflow.html

[Build Bot]

Created attachment 298329 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298328 [details]
Patch

Attachment 298328 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2856453

New failing tests:
fast/canvas/webgl/context-lost.html
webgl/1.0.2/conformance/state/gl-object-get-calls.html
fast/canvas/webgl/gl-object-get-calls.html
webgl/1.0.2/conformance/context/context-lost.html
fast/canvas/webgl/uniform-array-length-overflow.html

[Build Bot]

Created attachment 298330 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298328 [details]
Patch

Attachment 298328 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2856455

New failing tests:
fast/canvas/webgl/context-lost.html
webgl/1.0.2/conformance/state/gl-object-get-calls.html
fast/canvas/webgl/gl-object-get-calls.html
webgl/1.0.2/conformance/context/context-lost.html
fast/canvas/webgl/uniform-array-length-overflow.html

[Build Bot]

Created attachment 298332 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 298333 [details]
Patch

[Sam Weinig]

The timeout of uniform-array-length-overflow.html is interesting. It illustrates that our IDLSequence conversion code is just too slow. 

The custom code was doing it's conversion in toNumberVector, which got the length, and then did a get() for each integer between 0 and length. The generic IDL conversion code that I switched it to uses JSC's forEachInIterable(), which may just be too slow. I will look into speeding that up and/or special casing js arrays.

[Build Bot]

Comment on attachment 298333 [details]
Patch

Attachment 298333 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2856830

New failing tests:
fast/canvas/webgl/gl-object-get-calls.html
fast/canvas/webgl/uniform-array-length-overflow.html

[Build Bot]

Created attachment 298334 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298333 [details]
Patch

Attachment 298333 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2856828

New failing tests:
fast/canvas/webgl/gl-object-get-calls.html
fast/canvas/webgl/uniform-array-length-overflow.html

[Build Bot]

Created attachment 298335 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298333 [details]
Patch

Attachment 298333 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2856847

New failing tests:
fast/canvas/webgl/gl-object-get-calls.html
fast/canvas/webgl/uniform-array-length-overflow.html

[Build Bot]

Created attachment 298336 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 298483 [details]
Patch

[Sam Weinig]

Created attachment 298487 [details]
Patch

[WebKit Commit Bot]

Attachment 298487 [details] did not pass style-queue:


ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGlobalObjectInlines.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 298487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298487&action=review

> Source/WebCore/bindings/js/JSDOMConvert.h:1039
> +            JSC::JSObject* object = JSC::asObject(value);

This iteration code LGTM

> Source/WebCore/bindings/js/JSDOMConvert.h:1051
> +                // FIXME: Is the right exception to throw?

Or maybe OOM?

[Build Bot]

Comment on attachment 298487 [details]
Patch

Attachment 298487 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2865412

New failing tests:
fast/events/message-port-multi.html

[Build Bot]

Created attachment 298497 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298487 [details]
Patch

Attachment 298487 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2865413

New failing tests:
fast/events/message-port-multi.html

[Build Bot]

Created attachment 298498 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298487 [details]
Patch

Attachment 298487 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2865425

New failing tests:
fast/events/message-port-multi.html

[Build Bot]

Created attachment 298499 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298487 [details]
Patch

Attachment 298487 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2865447

New failing tests:
fast/events/message-port-multi.html

[Build Bot]

Created attachment 298504 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 298506 [details]
Patch

[WebKit Commit Bot]

Attachment 298506 [details] did not pass style-queue:


ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGlobalObjectInlines.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 298513 [details]
Patch

[WebKit Commit Bot]

Attachment 298513 [details] did not pass style-queue:


ERROR: Source/WebCore/ForwardingHeaders/runtime/JSGlobalObjectInlines.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Finally ready to be reviewed.

[Alex Christensen]

Comment on attachment 298513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298513&action=review

> Source/WebCore/Modules/indexeddb/IDBKeyRange.idl:31
> +    [OverrideIDLType=IDLIDBKey] readonly attribute any lower;

This isn't really related to removing WebGL bindings, is it?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5330
> +    # FIXME: We need a more robost way to specify this requirement so as not

robust

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5362
> +    # FIXME: We need a more robost way to specify this requirement so as not

robust

[WebKit Commit Bot]

Comment on attachment 298513 [details]
Patch

Clearing flags on attachment: 298513

Committed r210567: <http://trac.webkit.org/changeset/210567>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sam Weinig]

Reopening to attach new patch.

[Sam Weinig]

Created attachment 298760 [details]
Patch

[Sam Weinig]

Wrong bug.