Bug 166825 – Move cache coders to WTF

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Antti Koivisto]

Make it possible to use robust serialization of WTF types on the lower levels of the stack.

[Antti Koivisto]

Created attachment 298317 [details]
patch

[WebKit Commit Bot]

Attachment 298317 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/persistence/Encoder.h:94:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 298318 [details]
patch

[WebKit Commit Bot]

Attachment 298318 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/persistence/Encoder.h:94:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 298319 [details]
patch

[WebKit Commit Bot]

Attachment 298319 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/persistence/Encoder.h:94:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 298322 [details]
patch

[WebKit Commit Bot]

Attachment 298322 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/persistence/Encoder.h:94:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Catanzaro]

Comment on attachment 298319 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298319&action=review

> Source/WTF/wtf/persistence/Coders.cpp:35
> +#include "NetworkCacheCoders.h"
> +
> +#if ENABLE(NETWORK_CACHE)
> +
> +#include <wtf/text/CString.h>
> +#include <wtf/text/WTFString.h>
> +
> +namespace WebKit {
> +namespace NetworkCache {

Are you planning to get rid of the ENABLE(NETWORK_CACHE) and namespace NetworkCache?

> Source/WTF/wtf/persistence/Coders.cpp:160
> +// Store common HTTP headers as strings instead of using their value in the HTTPHeaderName enumeration
> +// so that the headers stored in the cache stays valid even after HTTPHeaderName.in gets updated.
> +void Coder<WebCore::HTTPHeaderMap>::encode(Encoder& encoder, const WebCore::HTTPHeaderMap& headers)

Er, surely WTF cannot depend on WebCore.

[Antti Koivisto]

> Are you planning to get rid of the ENABLE(NETWORK_CACHE) and namespace
> NetworkCache?
> Er, surely WTF cannot depend on WebCore.

If you look further in the patch you see them changed appropriately. This is just how move/edit patches end up looking like.

[Antti Koivisto]

Created attachment 298323 [details]
patch

[WebKit Commit Bot]

Attachment 298323 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/persistence/Encoder.h:94:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:95:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:97:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:98:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:99:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:100:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:101:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:102:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WTF/wtf/persistence/Encoder.h:103:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 298323 [details]
patch

Looks good, rs=me. What do you plan on persisting now :) ?

[Sam Weinig]

Probably useful to move NetworkCache::Data, NetworkCache::IOChannel, and the helpers in NetworkCacheFileSystem.h at some point. (As well as WebKit::SharedMemory I guess).

[Antti Koivisto]

> Looks good, rs=me. What do you plan on persisting now :) ?

JS related things!

[Antti Koivisto]

https://trac.webkit.org/r210502

[Konstantin Tokarev]

Comment on attachment 298323 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298323&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheCoders.h:43
> +namespace Persistence {

It does not feel right to have code in namespace WTF inside WebKit2

[Antti Koivisto]

> It does not feel right to have code in namespace WTF inside WebKit2

Nevertheless it is a rather common pattern for traits-like templates (search for it in WebCore).