Bug 166799 - Implement find-in-page in MiniBrowser
Summary: Implement find-in-page in MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-07 02:00 PST by Tim Horton
Modified: 2017-01-07 13:10 PST (History)
4 users (show)

See Also:


Attachments
Patch (15.88 KB, patch)
2017-01-07 02:02 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (13.48 KB, patch)
2017-01-07 02:17 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-01-07 02:00:46 PST
Implement find-in-page in MiniBrowser
Comment 1 Tim Horton 2017-01-07 02:02:04 PST
Created attachment 298262 [details]
Patch
Comment 2 Tim Horton 2017-01-07 02:02:50 PST
Implementation mostly cribbed from WebEditingTester. It's less broken there because that app doesn't have a top content inset, but I'm not really sure how it's possible that this feature is as broken as it is.
Comment 3 Tim Horton 2017-01-07 02:17:27 PST
Created attachment 298264 [details]
Patch
Comment 4 Andy Estes 2017-01-07 05:54:35 PST
Comment on attachment 298264 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298264&action=review

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:681
> +    [_textFindBarView setFrame:NSMakeRect(0, 0, containerView.bounds.size.width, _textFindBarView.frame.size.height)];

Should you use CGRectGet{Width,Height}() here to ensure the rect is normalized?
Comment 5 Tim Horton 2017-01-07 13:10:40 PST
Comment on attachment 298264 [details]
Patch

Clearing flags on attachment: 298264

Committed r210482: <http://trac.webkit.org/changeset/210482>
Comment 6 Tim Horton 2017-01-07 13:10:43 PST
All reviewed patches have been landed.  Closing bug.