Bug 166797 - Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Summary: Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-06 21:33 PST by Darin Adler
Modified: 2017-01-07 14:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (125.13 KB, patch)
2017-01-06 21:48 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (125.18 KB, patch)
2017-01-07 09:25 PST, Darin Adler 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2017-01-06 21:33:02 PST 
Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
Comment 1 Darin Adler 2017-01-06 21:48:48 PST 
Created attachment 298257 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-06 21:49:56 PST 
Attachment 298257 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyClients.cpp:210:  Declaration has space between type name and * in NSString *userVisibleString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:212:  Declaration has space between type name and * in NSURL *canonicalizeURL  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:213:  Declaration has space between type name and * in NSURL *canonicalizeURLString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:427:  Declaration has space between type name and * in NSCachedURLResponse *willCacheResponse  [whitespace/declaration] [3]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2017-01-07 09:25:37 PST 
Created attachment 298279 [details]
Patch
Comment 4 WebKit Commit Bot 2017-01-07 09:27:05 PST 
Attachment 298279 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyClients.cpp:211:  Declaration has space between type name and * in NSString *userVisibleString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:213:  Declaration has space between type name and * in NSURL *canonicalizeURL  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:214:  Declaration has space between type name and * in NSURL *canonicalizeURLString  [whitespace/declaration] [3]
ERROR: Source/WebCore/loader/EmptyClients.cpp:428:  Declaration has space between type name and * in NSCachedURLResponse *willCacheResponse  [whitespace/declaration] [3]
Total errors found: 4 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Adler 2017-01-07 14:09:29 PST 
Committed r210492: <http://trac.webkit.org/changeset/210492>