Bug 166793 – [WebIDL] Remove custom bindings from CanvasRenderingContext2D

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Remove custom bindings from CanvasRenderingContext2D

[Sam Weinig]

Created attachment 298245 [details]
Patch

[Darin Adler]

Comment on attachment 298245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298245&action=review

> Source/WebCore/ChangeLog:29
> +        Move existing setStrokeStyle/setFillStyle functions (which take CanvasStyle's) 
> +        down, and implement new ones that operate on Variants, matching the spec.

What does it mean to "move the existing functions down"? I guess you mean you made them private.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1653
> +void CanvasRenderingContext2D::setStrokeStyle(CanvasStyle style)

Not sure you really need to move these in the source file, especially since I assume you aren’t otherwise changing them in this patch.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1709
> +    if (auto* gradiant = style.canvasGradient())

Spelling error here, gradient has an "e".

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1725
> +        [this] (const RefPtr<CanvasGradient>& gradiant) { this->setStrokeStyle(CanvasStyle(*gradiant)); },

Spelling error here, gradient has an "e".

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1739
> +        [this] (const RefPtr<CanvasGradient>& gradiant) { this->setFillStyle(CanvasStyle(*gradiant)); },

Spelling error here, gradient has an "e".

[Sam Weinig]

Committed r210470: <http://trac.webkit.org/changeset/210470>