Bug 166789 - [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
Summary: [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-06 18:02 PST by Andy Estes
Modified: 2017-01-06 22:22 PST (History)
9 users (show)

See Also:

Attachments
Patch (78.09 KB, patch)
2017-01-06 18:10 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (78.21 KB, patch)
2017-01-06 18:23 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (78.21 KB, patch)
2017-01-06 19:12 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-06 18:02:28 PST 
[Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
Comment 1 Andy Estes 2017-01-06 18:10:24 PST 
Created attachment 298241 [details]
Patch
Comment 2 Andy Estes 2017-01-06 18:23:00 PST 
Created attachment 298243 [details]
Patch
Comment 3 Alex Christensen 2017-01-06 18:25:50 PST 
Comment on attachment 298243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298243&action=review

> Source/WebCore/PlatformMac.cmake:747
> +    bindings/cocoa/WebArchiveDumpSupport.mm

bindings?
Comment 4 Andy Estes 2017-01-06 18:36:38 PST 
(In reply to comment #3)
> Comment on attachment 298243 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298243&action=review
> 
> > Source/WebCore/PlatformMac.cmake:747
> > +    bindings/cocoa/WebArchiveDumpSupport.mm
> 
> bindings?

Oops! Will fix.
Comment 5 Andy Estes 2017-01-06 19:10:33 PST 
Alex reviewed in person.
Comment 6 Andy Estes 2017-01-06 19:12:55 PST 
Created attachment 298248 [details]
Patch
Comment 7 WebKit Commit Bot 2017-01-06 19:50:03 PST 
Comment on attachment 298248 [details]
Patch

Clearing flags on attachment: 298248

Committed r210467: <http://trac.webkit.org/changeset/210467>
Comment 8 WebKit Commit Bot 2017-01-06 19:50:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Joseph Pecoraro 2017-01-06 20:01:28 PST 
View in context: https://bugs.webkit.org/attachment.cgi?id=298243&action=review

> Source/WebCore/platform/spi/cf/CFNetworkSPI.h:186
> +CFTypeID CFURLResponseGetTypeID();

No code actually uses this. Do we expect any code to use it?

> Source/WebCore/platform/spi/cf/CFNetworkSPI.h:188
> +void CFURLResponseSetExpectedContentLength(CFURLResponseRef, SInt64 length);

No code actually uses this. Do we expect any code to use it?
Comment 10 Simon Fraser (smfr) 2017-01-06 22:09:52 PST 
Why not put the files in Tools/TestRunnerShared/ ?
Comment 11 Csaba Osztrogonác 2017-01-06 22:22:10 PST 
(In reply to comment #7)
> Comment on attachment 298248 [details]
> Patch
> 
> Clearing flags on attachment: 298248
> 
> Committed r210467: <http://trac.webkit.org/changeset/210467>

It broke the Apple Mac cmake build. https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/11115