Bug 166781 – Add infrastructure for sending autoplay website policies to WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

This tracks adding infrastructure for sending autoplay website policies to WebKit.

[Matt Rajca]

Created attachment 298233 [details]
Patch

[Alex Christensen]

Comment on attachment 298233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298233&action=review

api doesn't affect behavior yet.

> Source/WebKit2/Shared/WebsitePolicies.h:49
> +    encoder << autoplayPolicy;

Can we use encodeEnum instead of typedefing to an integer?

[Matt Rajca]

(In reply to comment #2)
> Comment on attachment 298233 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298233&action=review
> 
> api doesn't affect behavior yet.
> 
> > Source/WebKit2/Shared/WebsitePolicies.h:49
> > +    encoder << autoplayPolicy;
> 
> Can we use encodeEnum instead of typedefing to an integer?

Done.

[Matt Rajca]

Created attachment 298235 [details]
Patch

[Matt Rajca]

Created attachment 298236 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 298236 [details]
Patch

Clearing flags on attachment: 298236

Committed r210461: <http://trac.webkit.org/changeset/210461>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

(In reply to comment #6)
> Comment on attachment 298236 [details]
> Patch
> 
> Clearing flags on attachment: 298236
> 
> Committed r210461: <http://trac.webkit.org/changeset/210461>

This broke the EFL port:
[[
FAILED: [...] ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp
../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp: In function ‘WKWebsiteAutoplayPolicy WKWebsitePoliciesGetAutoplayPolicy(WKWebsitePoliciesRef)’:
../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp:65:1: error: control reaches end of non-void function [-Werror=return-type]
 }
]]
<https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/31194/steps/compile-webkit/logs/stdio>

[Daniel Bates]

(In reply to comment #8)
> (In reply to comment #6)
> > Comment on attachment 298236 [details]
> > Patch
> > 
> > Clearing flags on attachment: 298236
> > 
> > Committed r210461: <http://trac.webkit.org/changeset/210461>
> 
> This broke the EFL port:
> [[
> FAILED: [...] ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp
> ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp: In function
> ‘WKWebsiteAutoplayPolicy
> WKWebsitePoliciesGetAutoplayPolicy(WKWebsitePoliciesRef)’:
> ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp:65:1: error:
> control reaches end of non-void function [-Werror=return-type]
>  }
> ]]
> <https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/
> builds/31194/steps/compile-webkit/logs/stdio>

Committed attempt to fix the build in <http://trac.webkit.org/changeset/210475>.