Simple line layout does not honor CJK keep-all word wrapping.
rdar://problem/29778563
Created attachment 298176 [details] Patch
Comment on attachment 298176 [details] Patch Attachment 298176 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2842403 Number of test failures exceeded the failure limit.
Created attachment 298180 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
(In reply to comment #3) > Comment on attachment 298176 [details] > Patch > > Attachment 298176 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/2842403 > > Number of test failures exceeded the failure limit. It looks more like an EWS failure -> "Failed to run PrettyPatch, see error log."
Created attachment 298215 [details] Patch
Created attachment 298217 [details] Patch
Comment on attachment 298217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298217&action=review > Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp:133 > + auto nextBreakablePositionForSegment = [this] (unsigned startPosition, bool breakNBSP, bool keepAllWordsForCJK) { > + if (keepAllWordsForCJK) { > + if (breakNBSP) > + return nextBreakablePositionKeepingAllWords(m_lineBreakIterator, startPosition); > + return nextBreakablePositionKeepingAllWordsIgnoringNBSP(m_lineBreakIterator, startPosition); > + } > + > + if (m_lineBreakIterator.isLooseCJKMode()) { > + if (breakNBSP) > + return nextBreakablePositionLoose(m_lineBreakIterator, startPosition); > + return nextBreakablePositionIgnoringNBSPLoose(m_lineBreakIterator, startPosition); > + } > + > + if (breakNBSP) > + return WebCore::nextBreakablePosition(m_lineBreakIterator, startPosition); > + return nextBreakablePositionIgnoringNBSP(m_lineBreakIterator, startPosition); > + }; Seems like this could be done with a pointer-to-member function instead of a lambda.
Created attachment 298229 [details] Patch
or since I only need the lazyiterator from 'this', I could just come up with a static function.
Comment on attachment 298229 [details] Patch Clearing flags on attachment: 298229 Committed r210456: <http://trac.webkit.org/changeset/210456>
All reviewed patches have been landed. Closing bug.