WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
166742
AutomaticThread timeout shutdown leaves a small window where notify() would think that the thread is still running
https://bugs.webkit.org/show_bug.cgi?id=166742
Summary
AutomaticThread timeout shutdown leaves a small window where notify() would t...
Filip Pizlo
Reported
2017-01-05 14:17:09 PST
Patch forthcoming.
Attachments
the patch
(8.07 KB, patch)
2017-01-05 14:22 PST
,
Filip Pizlo
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2017-01-05 14:22:08 PST
Created
attachment 298133
[details]
the patch
WebKit Commit Bot
Comment 2
2017-01-05 14:24:31 PST
Attachment 298133
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/AutomaticThread.cpp:164: 'thread' is incorrectly named. It should be named 'protector' or 'protectedPreserveThisForThread'. [readability/naming/protected] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3
2017-01-05 14:24:56 PST
Comment on
attachment 298133
[details]
the patch r=me
Filip Pizlo
Comment 4
2017-01-05 16:25:27 PST
Landed in
https://trac.webkit.org/changeset/210398
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug