Bug 166742 - AutomaticThread timeout shutdown leaves a small window where notify() would think that the thread is still running
Summary: AutomaticThread timeout shutdown leaves a small window where notify() would t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-05 14:17 PST by Filip Pizlo
Modified: 2017-01-05 16:25 PST (History)
9 users (show)

See Also:

Attachments
the patch (8.07 KB, patch)
2017-01-05 14:22 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-01-05 14:17:09 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-01-05 14:22:08 PST 
Created attachment 298133 [details]
the patch
Comment 2 WebKit Commit Bot 2017-01-05 14:24:31 PST 
Attachment 298133 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/AutomaticThread.cpp:164:  'thread' is incorrectly named. It should be named 'protector' or 'protectedPreserveThisForThread'.  [readability/naming/protected] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2017-01-05 14:24:56 PST 
Comment on attachment 298133 [details]
the patch

r=me
Comment 4 Filip Pizlo 2017-01-05 16:25:27 PST 
Landed in https://trac.webkit.org/changeset/210398