Bug 166717 – Remove PassRefPtr use from "rendering" directory, other improvements

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Darin Adler]

Remove PassRefPtr use from "rendering" directory, other improvements

[Darin Adler]

Created attachment 298070 [details]
Patch

[Build Bot]

Comment on attachment 298070 [details]
Patch

Attachment 298070 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2836764

New failing tests:
css3/filters/css-opacity-with-drop-shadow.html
imported/blink/css3/filters/effect-reference-source-alpha-not-first.html
css3/filters/drop-shadow-blur-radius.html
imported/blink/css3/filters/effect-reference-add-hw.html
fast/filter-image/background-filter-image.html
fast/filter-image/filter-image.html
svg/filters/sourceAlpha-input-filter-effect.html
css3/masking/clip-path-filter.html
fast/css/drop-shadow-viewport-height.html
fast/css/drop-shadow-viewport-vmin.html
css3/filters/drop-shadow.html
fast/css/drop-shadow-viewport-width.html
fast/hidpi/filters-morphology.html
fast/css/drop-shadow-viewport-vmax.html
imported/blink/css3/filters/effect-reference-source-alpha-hw.html
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 298075 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298070 [details]
Patch

Attachment 298070 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2836768

New failing tests:
css3/filters/css-opacity-with-drop-shadow.html
imported/blink/css3/filters/effect-reference-source-alpha-not-first.html
css3/filters/drop-shadow-blur-radius.html
svg/filters/sourceAlpha-input-filter-effect.html
fast/filter-image/background-filter-image.html
fast/filter-image/filter-image.html
imported/blink/css3/filters/effect-reference-add-hw.html
css3/masking/clip-path-filter.html
fast/css/drop-shadow-viewport-height.html
fast/css/drop-shadow-viewport-vmin.html
css3/filters/drop-shadow.html
fast/css/drop-shadow-viewport-width.html
fast/hidpi/filters-morphology.html
fast/css/drop-shadow-viewport-vmax.html
imported/blink/css3/filters/effect-reference-source-alpha-hw.html
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 298076 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298070 [details]
Patch

Attachment 298070 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2836769

New failing tests:
css3/filters/css-opacity-with-drop-shadow.html
imported/blink/css3/filters/effect-reference-source-alpha-not-first.html
css3/filters/drop-shadow-blur-radius.html
svg/filters/sourceAlpha-input-filter-effect.html
fast/filter-image/background-filter-image.html
fast/filter-image/filter-image.html
imported/blink/css3/filters/effect-reference-add-hw.html
css3/masking/clip-path-filter.html
fast/css/drop-shadow-viewport-height.html
fast/css/drop-shadow-viewport-vmin.html
css3/filters/drop-shadow.html
fast/css/drop-shadow-viewport-width.html
fast/hidpi/filters-morphology.html
fast/css/drop-shadow-viewport-vmax.html
imported/blink/css3/filters/effect-reference-source-alpha-hw.html
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 298077 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 298070 [details]
Patch

Attachment 298070 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2836770

New failing tests:
css3/filters/css-opacity-with-drop-shadow.html
imported/blink/css3/filters/effect-reference-source-alpha-not-first.html
css3/filters/drop-shadow-blur-radius.html
imported/blink/css3/filters/effect-reference-add-hw.html
fast/filter-image/filter-image.html
svg/filters/sourceAlpha-input-filter-effect.html
css3/masking/clip-path-filter.html
fast/css/drop-shadow-viewport-vmin.html
css3/filters/drop-shadow.html
fast/css/drop-shadow-viewport-width.html
fast/hidpi/filters-morphology.html
fast/css/drop-shadow-viewport-vmax.html
imported/blink/css3/filters/effect-reference-source-alpha-hw.html
imported/blink/css3/filters/effect-reference-on-transparent-element.html

[Build Bot]

Created attachment 298078 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Darin Adler]

Created attachment 298168 [details]
Patch

[Build Bot]

Comment on attachment 298168 [details]
Patch

Attachment 298168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2841692

New failing tests:
css3/filters/filter-mask-clip-order.html

[Build Bot]

Created attachment 298171 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Comment on attachment 298168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298168&action=review

> Source/WebCore/rendering/style/NinePieceImage.h:37
> +enum ENinePieceImageRule { StretchImageRule, RoundImageRule, SpaceImageRule, RepeatImageRule };

We need to do a single pass and remove all the remaining E prefixes. Eww.

> Source/WebCore/rendering/style/ShapeValue.h:40
> +    static Ref<ShapeValue> create(RefPtr<BasicShape>&& shape, CSSBoxType cssBox)

Can this take a Ref<BasicShape>&&, it looks like all the callers guarantee it's non-null.

> Source/WebCore/rendering/style/ShapeValue.h:50
> +    static Ref<ShapeValue> create(RefPtr<StyleImage>&& image)

Same question.

[Darin Adler]

Committed r210469: <http://trac.webkit.org/changeset/210469>

[Darin Adler]

Comment on attachment 298168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298168&action=review

>> Source/WebCore/rendering/style/ShapeValue.h:40
>> +    static Ref<ShapeValue> create(RefPtr<BasicShape>&& shape, CSSBoxType cssBox)
> 
> Can this take a Ref<BasicShape>&&, it looks like all the callers guarantee it's non-null.

Oops, forgot to do this. Will follow up.

>> Source/WebCore/rendering/style/ShapeValue.h:50
>> +    static Ref<ShapeValue> create(RefPtr<StyleImage>&& image)
> 
> Same question.

Ditto.