Bug 166713 – [QuickLook] Consolidate usage of QuickLookHandle into SubresourceLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[QuickLook] Consolidate usage of QuickLookHandle into SubresourceLoader

[Andy Estes]

Created attachment 298065 [details]
Patch

[WebKit Commit Bot]

Attachment 298065 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 298272 [details]
Patch

[Alex Christensen]

Comment on attachment 298272 [details]
Patch

ahhhhh, much better.
I guess we're ok with appcache not using quicklook for now?  See ApplicationCacheGroup, which we ought to also fix so it's not loading in the WebProcess.  It uses ResourceHandle directly right now.

[Andy Estes]

(In reply to comment #4)
> Comment on attachment 298272 [details]
> Patch
> 
> ahhhhh, much better.
> I guess we're ok with appcache not using quicklook for now?  See
> ApplicationCacheGroup, which we ought to also fix so it's not loading in the
> WebProcess.  It uses ResourceHandle directly right now.

Yeah, we're ok with this. Documents converted by QuickLook can't have a cache manifest (they aren't HTML), and can't be specified in a cache manifest (they're only loaded as main resources).

The old ResourceHandle code would've never even created a QuickLookHandle for ApplicationCacheGroup loads, since it checked that firstRequest's requester was Requester::Main, which is only set by DocumentLoader.

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 298272 [details]
Patch

Clearing flags on attachment: 298272

Committed r210480: <http://trac.webkit.org/changeset/210480>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.