Bug 166711 - Carets can split up marriages and families
Summary: Carets can split up marriages and families
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-04 19:46 PST by Myles C. Maxfield
Modified: 2017-01-05 17:05 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.03 KB, patch)
2017-01-04 19:54 PST, Myles C. Maxfield 		achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (16.44 MB, application/zip)
2017-01-04 21:45 PST, Build Bot 		no flags Details
Patch for commiting (15.88 KB, patch)
2017-01-05 15:41 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (15.95 KB, patch)
2017-01-05 15:48 PST, Myles C. Maxfield 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-01-04 19:46:45 PST 
Carets can split up marriages and families
Comment 1 Myles C. Maxfield 2017-01-04 19:54:31 PST 
Created attachment 298061 [details]
Patch
Comment 2 Myles C. Maxfield 2017-01-04 19:55:45 PST 
<rdar://problem/29019333>
Comment 3 Alex Christensen 2017-01-04 21:18:42 PST 
Comment on attachment 298061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298061&action=review

r=me
ews failure is unrelated and from https://trac.webkit.org/changeset/210313

> Source/WTF/ChangeLog:3
> +        Carets can split up marriages and families

This sounds awful :(
Comment 4 Build Bot 2017-01-04 21:45:40 PST 
Comment on attachment 298061 [details]
Patch

Attachment 298061 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2836105

New failing tests:
editing/caret/emoji.html
Comment 5 Build Bot 2017-01-04 21:45:45 PST 
Created attachment 298067 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Myles C. Maxfield 2017-01-05 15:41:50 PST 
Created attachment 298146 [details]
Patch for commiting
Comment 7 Myles C. Maxfield 2017-01-05 15:48:45 PST 
Created attachment 298147 [details]
Patch for committing
Comment 8 WebKit Commit Bot 2017-01-05 17:02:32 PST 
Comment on attachment 298147 [details]
Patch for committing

Rejecting attachment 298147 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 298147, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2840883
Comment 9 Myles C. Maxfield 2017-01-05 17:05:36 PST 
Committed r210399: <http://trac.webkit.org/changeset/210399>