Add feature flag for Async iteration
Created attachment 317099 [details] Patch
Created attachment 317107 [details] Patch Rebase
Created attachment 317113 [details] Patch Fix 32bit build
For JS features, I think adding a flag to Options is the easiest way.
Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4246236 Number of test failures exceeded the failure limit.
Created attachment 317119 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4246207 Number of test failures exceeded the failure limit.
Created attachment 317120 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4246394 New failing tests: inspector/debugger/tail-deleted-frames-from-vm-entry.html inspector/debugger/pause-reason.html inspector/debugger/call-frame-this-host.html inspector/debugger/breakpoint-eval-with-exception.html inspector/debugger/removeBreakpoint.html inspector/debugger/setBreakpoint-column.html inspector/debugger/hit-breakpoint-from-console.html inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/setBreakpoint-autoContinue.html inspector/debugger/breakpoint-condition-with-exception.html inspector/debugger/setBreakpoint-actions.html inspector/debugger/call-frame-function-name.html inspector/debugger/setBreakpoint-condition.html inspector/debugger/breakpoint-action-detach.html inspector/debugger/setBreakpoint.html inspector/debugger/setBreakpoint-options-exception.html inspector/runtime/parse.html inspector/debugger/setBreakpointByUrl-sourceURL.html inspector/debugger/breakpoint-condition-with-bad-script.html inspector/debugger/breakpoint-inside-conditons-and-actions.html inspector/debugger/breakpoint-condition-detach.html inspector/debugger/call-frame-this-nonstrict.html inspector/debugger/call-frame-this-strict.html
Created attachment 317121 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4246839 New failing tests: inspector/debugger/tail-deleted-frames-from-vm-entry.html inspector/debugger/pause-reason.html inspector/debugger/call-frame-this-host.html inspector/debugger/breakpoint-eval-with-exception.html inspector/debugger/removeBreakpoint.html inspector/debugger/setBreakpoint-column.html inspector/debugger/hit-breakpoint-from-console.html inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/setBreakpoint-autoContinue.html inspector/debugger/breakpoint-condition-with-exception.html inspector/debugger/setBreakpoint-actions.html inspector/debugger/call-frame-function-name.html inspector/debugger/setBreakpoint-condition.html inspector/debugger/breakpoint-action-detach.html inspector/debugger/setBreakpoint.html inspector/debugger/setBreakpoint-options-exception.html inspector/runtime/parse.html inspector/debugger/setBreakpointByUrl-sourceURL.html inspector/debugger/breakpoint-condition-with-bad-script.html inspector/debugger/breakpoint-inside-conditons-and-actions.html inspector/debugger/breakpoint-condition-detach.html inspector/debugger/call-frame-this-nonstrict.html inspector/debugger/call-frame-this-strict.html
Created attachment 317128 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 317221 [details] Patch
Comment on attachment 317221 [details] Patch r=me
Created attachment 317222 [details] Patch Reimplement with using Options.h
Comment on attachment 317222 [details] Patch Clearing flags on attachment: 317222 Committed r220262: <http://trac.webkit.org/changeset/220262>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33720032>
Comment on attachment 317222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317222&action=review > Source/JavaScriptCore/runtime/Options.h:517 > + v(enableAsyncIterator, useAsyncIterator, SameOption) \ Nit: This is just for legacy options. We don't need to do this for new options.