Summary: Add some missing longhand properties to CSSComputedStyleDeclaration and fix default values Test: <style> body { counter-reset: my-counter; } #x { counter-increment: object; } #x:before { content: "Before (" counter(my-counter) ") "; counter-increment: my-counter; } #x:after { content: " After (" counter(my-counter) ")"; counter-increment: my-counter; } </style> <div id="x">Test</div> Steps to Reproduce: 1. Inspect div#x on test page 2. Show computed styles => "counter-increment" does not show up, but it is expected Notes: - This is because "counter-increment" doesn't show up in the numeric list of all longhand properties in: getComputedStyle(elem) - Adding it to that list makes it show up in the inspector - Auditing all our longhand properties there are plenty that could be in this list that are not.
<rdar://problem/6026159>
Created attachment 297989 [details] [PATCH] Proposed Fix
Comment on attachment 297989 [details] [PATCH] Proposed Fix Looks like one SVG test still needs fixing.
(In reply to comment #3) > Comment on attachment 297989 [details] > [PATCH] Proposed Fix > > Looks like one SVG test still needs fixing. How can I see what that one SVG test was? =/
Got it: Regressions: Unexpected text-only failures (1) svg/css/getComputedStyle-basic.xhtml [ Failure ]
Created attachment 298130 [details] [PATCH] Proposed Fix
Comment on attachment 298130 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=298130&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1865 > + return CSSValuePool::singleton().createIdentifierValue(CSSValueNone); Given this function no longer ever returns null, its return type should be changed from RefPtr to Ref.
Created attachment 298218 [details] [PATCH] For Landing
Comment on attachment 298218 [details] [PATCH] For Landing Clearing flags on attachment: 298218 Committed r210449: <http://trac.webkit.org/changeset/210449>