WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
166673
Place all the Cocoa WebCore API tests in the same directory
https://bugs.webkit.org/show_bug.cgi?id=166673
Summary
Place all the Cocoa WebCore API tests in the same directory
Andy Estes
Reported
2017-01-03 18:41:07 PST
Place all the Cocoa WebCore API tests in the same directory
Attachments
Patch
(40.48 KB, patch)
2017-01-03 18:44 PST
,
Andy Estes
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andy Estes
Comment 1
2017-01-03 18:44:32 PST
Created
attachment 297982
[details]
Patch
WebKit Commit Bot
Comment 2
2017-01-03 18:47:09 PST
Attachment 297982
[details]
did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 3
2017-01-03 19:50:06 PST
Comment on
attachment 297982
[details]
Patch Thanks!
WebKit Commit Bot
Comment 4
2017-01-03 19:52:59 PST
Comment on
attachment 297982
[details]
Patch Clearing flags on attachment: 297982 Committed
r210268
: <
http://trac.webkit.org/changeset/210268
>
WebKit Commit Bot
Comment 5
2017-01-03 19:53:02 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug