Bug 166673 - Place all the Cocoa WebCore API tests in the same directory
Summary: Place all the Cocoa WebCore API tests in the same directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-03 18:41 PST by Andy Estes
Modified: 2017-01-03 19:53 PST (History)
6 users (show)

See Also:

Attachments
Patch (40.48 KB, patch)
2017-01-03 18:44 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-03 18:41:07 PST 
Place all the Cocoa WebCore API tests in the same directory
Comment 1 Andy Estes 2017-01-03 18:44:32 PST 
Created attachment 297982 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-03 18:47:09 PST 
Attachment 297982 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Catanzaro 2017-01-03 19:50:06 PST 
Comment on attachment 297982 [details]
Patch

Thanks!
Comment 4 WebKit Commit Bot 2017-01-03 19:52:59 PST 
Comment on attachment 297982 [details]
Patch

Clearing flags on attachment: 297982

Committed r210268: <http://trac.webkit.org/changeset/210268>
Comment 5 WebKit Commit Bot 2017-01-03 19:53:02 PST 
All reviewed patches have been landed.  Closing bug.