Bug 166672 - [Cocoa] Variation fonts without variations specified are not rendered as if the default variations were specified
Summary: [Cocoa] Variation fonts without variations specified are not rendered as if t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 166667 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-01-03 17:20 PST by Myles C. Maxfield
Modified: 2017-01-18 13:41 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2017-01-03 17:22 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (5.28 KB, patch)
2017-01-03 19:12 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2017-01-03 19:17 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (5.51 KB, patch)
2017-01-09 16:37 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (13.60 KB, patch)
2017-01-17 18:16 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-01-03 17:20:11 PST 
[Cocoa] Variation fonts without variations specified are not rendered as if the default variations were specified
Comment 1 Myles C. Maxfield 2017-01-03 17:22:14 PST 
Created attachment 297974 [details]
Patch
Comment 2 Myles C. Maxfield 2017-01-03 19:12:20 PST 
Created attachment 297983 [details]
Patch
Comment 3 Myles C. Maxfield 2017-01-03 19:17:15 PST 
Created attachment 297985 [details]
Patch
Comment 4 Myles C. Maxfield 2017-01-03 19:17:28 PST 
*** Bug 166667 has been marked as a duplicate of this bug. ***
Comment 5 Myles C. Maxfield 2017-01-03 19:18:46 PST 
<rdar://problem/29779119>
Comment 6 Darin Adler 2017-01-04 15:45:31 PST 
Comment on attachment 297985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297985&action=review

> Source/WebCore/ChangeLog:15
> +        Test: fast/text/variations/advances.html

This is a pre-existing test? I don’t see it failing. So how can it be that this test covers the bug we are fixing?
Comment 7 Myles C. Maxfield 2017-01-04 20:37:42 PST 
(In reply to comment #6)
> Comment on attachment 297985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297985&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +        Test: fast/text/variations/advances.html
> 
> This is a pre-existing test? I don’t see it failing. So how can it be that
> this test covers the bug we are fixing?

It's failing on our internal bots.
Comment 8 WebKit Commit Bot 2017-01-05 12:32:26 PST 
Comment on attachment 297985 [details]
Patch

Clearing flags on attachment: 297985

Committed r210370: <http://trac.webkit.org/changeset/210370>
Comment 9 WebKit Commit Bot 2017-01-05 12:32:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Ryan Haddad 2017-01-05 13:36:04 PST 
Reverted r210370 for reason:

This change caused hundreds of LayoutTest failures on Sierra.

Committed r210375: <http://trac.webkit.org/changeset/210375>
Comment 11 Ryan Haddad 2017-01-05 13:37:00 PST 
(In reply to comment #10)
> Reverted r210370 for reason:
> 
> This change caused hundreds of LayoutTest failures on Sierra.
> 
> Committed r210375: <http://trac.webkit.org/changeset/210375>

Link to test run with failures:

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2531
Comment 12 Myles C. Maxfield 2017-01-07 13:54:56 PST 
(In reply to comment #11)
> (In reply to comment #10)
> > Reverted r210370 for reason:
> > 
> > This change caused hundreds of LayoutTest failures on Sierra.
> > 
> > Committed r210375: <http://trac.webkit.org/changeset/210375>
> 
> Link to test run with failures:
> 
> https://build.webkit.org/builders/
> Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2531

Looks like this is because of the system font
Comment 13 Myles C. Maxfield 2017-01-09 16:37:02 PST 
Created attachment 298414 [details]
Patch for committing
Comment 14 WebKit Commit Bot 2017-01-11 10:27:43 PST 
Comment on attachment 298414 [details]
Patch for committing

Clearing flags on attachment: 298414

Committed r210591: <http://trac.webkit.org/changeset/210591>
Comment 15 WebKit Commit Bot 2017-01-11 10:27:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 16 Myles C. Maxfield 2017-01-11 12:07:42 PST 
Caused fast/text/trak-optimizeLegibility.html and fast/text/system-font-features.html to fail
Comment 17 Myles C. Maxfield 2017-01-11 13:41:38 PST 
Committed r210597: <http://trac.webkit.org/changeset/210597>
Comment 18 Myles C. Maxfield 2017-01-11 13:47:58 PST 
Committed r210598: <http://trac.webkit.org/changeset/210598>
Comment 20 Ryan Haddad 2017-01-11 17:55:39 PST 
Reverted changes in https://trac.webkit.org/r210612 because the iOS simulator build is still broken:
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20%28Build%29/builds/3159
Comment 21 Myles C. Maxfield 2017-01-14 14:03:04 PST 
The build failure on the iOS simulator is quite confusing. A build works locally, and I can't figure out what went wrong from inspection.
Comment 22 Myles C. Maxfield 2017-01-17 18:16:28 PST 
Created attachment 299099 [details]
Patch for committing
Comment 23 Myles C. Maxfield 2017-01-18 13:41:40 PST 
Committed r210883: <http://trac.webkit.org/changeset/210883>