Bug 166672 – [Cocoa] Variation fonts without variations specified are not rendered as if the default variations were specified

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Variation fonts without variations specified are not rendered as if the default variations were specified

[Myles C. Maxfield]

Created attachment 297974 [details]
Patch

[Myles C. Maxfield]

Created attachment 297983 [details]
Patch

[Myles C. Maxfield]

Created attachment 297985 [details]
Patch

[Myles C. Maxfield]

*** Bug 166667 has been marked as a duplicate of this bug. ***

[Myles C. Maxfield]

<rdar://problem/29779119>

[Darin Adler]

Comment on attachment 297985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297985&action=review

> Source/WebCore/ChangeLog:15
> +        Test: fast/text/variations/advances.html

This is a pre-existing test? I don’t see it failing. So how can it be that this test covers the bug we are fixing?

[Myles C. Maxfield]

(In reply to comment #6)
> Comment on attachment 297985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297985&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +        Test: fast/text/variations/advances.html
> 
> This is a pre-existing test? I don’t see it failing. So how can it be that
> this test covers the bug we are fixing?

It's failing on our internal bots.

[WebKit Commit Bot]

Comment on attachment 297985 [details]
Patch

Clearing flags on attachment: 297985

Committed r210370: <http://trac.webkit.org/changeset/210370>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Reverted r210370 for reason:

This change caused hundreds of LayoutTest failures on Sierra.

Committed r210375: <http://trac.webkit.org/changeset/210375>

[Ryan Haddad]

(In reply to comment #10)
> Reverted r210370 for reason:
> 
> This change caused hundreds of LayoutTest failures on Sierra.
> 
> Committed r210375: <http://trac.webkit.org/changeset/210375>

Link to test run with failures:

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2531

[Myles C. Maxfield]

(In reply to comment #11)
> (In reply to comment #10)
> > Reverted r210370 for reason:
> > 
> > This change caused hundreds of LayoutTest failures on Sierra.
> > 
> > Committed r210375: <http://trac.webkit.org/changeset/210375>
> 
> Link to test run with failures:
> 
> https://build.webkit.org/builders/
> Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2531

Looks like this is because of the system font

[Myles C. Maxfield]

Created attachment 298414 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 298414 [details]
Patch for committing

Clearing flags on attachment: 298414

Committed r210591: <http://trac.webkit.org/changeset/210591>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Myles C. Maxfield]

Caused fast/text/trak-optimizeLegibility.html and fast/text/system-font-features.html to fail

[Myles C. Maxfield]

Committed r210597: <http://trac.webkit.org/changeset/210597>

[Myles C. Maxfield]

Committed r210598: <http://trac.webkit.org/changeset/210598>

[Myles C. Maxfield]

https://trac.webkit.org/changeset/210598
https://trac.webkit.org/changeset/210597

[Ryan Haddad]

Reverted changes in https://trac.webkit.org/r210612 because the iOS simulator build is still broken:
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20%28Build%29/builds/3159

[Myles C. Maxfield]

The build failure on the iOS simulator is quite confusing. A build works locally, and I can't figure out what went wrong from inspection.

[Myles C. Maxfield]

Created attachment 299099 [details]
Patch for committing

[Myles C. Maxfield]

Committed r210883: <http://trac.webkit.org/changeset/210883>