Bug 166664 - Web Inspector: "Invalid Characters" setting does the opposite of the checkbox
Summary: Web Inspector: "Invalid Characters" setting does the opposite of the checkbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-03 14:39 PST by Joseph Pecoraro
Modified: 2017-01-03 15:07 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.49 KB, patch)
2017-01-03 14:40 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-03 14:39:23 PST 
Summary:
"Invalid Characters" setting does the opposite of the checkbox

Steps to Reproduce:
1. Inspect http://www.apple.com/kr/watchos/
2. Uncheck "Invalid Characters" in Web Inspector's Preferences Tab
3. Show one of the font Stylesheets in the Resources Tab
  => ␍ characters show
4. Check "Invalid Characters" in Web Inspector's Preferences Tab
  => ␍ characters do not show

Seems this setting is inverted!
Comment 1 Joseph Pecoraro 2017-01-03 14:40:23 PST 
Created attachment 297955 [details]
[PATCH] Proposed Fix
Comment 2 Radar WebKit Bug Importer 2017-01-03 14:41:00 PST 
<rdar://problem/29854762>
Comment 3 BJ Burg 2017-01-03 14:43:12 PST 
Comment on attachment 297955 [details]
[PATCH] Proposed Fix

r=me

@_@
Comment 4 WebKit Commit Bot 2017-01-03 15:07:48 PST 
Comment on attachment 297955 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 297955

Committed r210252: <http://trac.webkit.org/changeset/210252>
Comment 5 WebKit Commit Bot 2017-01-03 15:07:54 PST 
All reviewed patches have been landed.  Closing bug.