Bug 166661 - It should not be possible to set track language for in-band media
Summary: It should not be possible to set track language for in-band media
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-03 13:51 PST by John Wilander
Modified: 2017-01-03 13:51 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2017-01-03 13:51:12 PST 
TrackBase::setLanguage() currently allows any track element to set language. The setter should first check that the track is not in-band, for instance through a convenience function in HTMLMediaElement.

This change should get rid of the ENABLE(MEDIA_SOURCE) in JSTextTrack::setLanguage() (see JSTextTrackCustom.cpp). Possibly even get rid of the custom setter all together, see [CustomSetter] attribute DOMString language in TextTrack.idl.

This change will correct the expected test results from https://bugs.webkit.org/show_bug.cgi?id=123926.