Bug 166659 – Rename the directory and the files of MotionMark from Animometer to MotionMark

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Said Abou-Hallawa]

After renaming the graphics benchmark from Animometer to MotionMark, we need to change the directory and all the files whose names are Animometer as well.

[Said Abou-Hallawa]

Created attachment 297950 [details]
Patch

[Jon Lee]

Comment on attachment 297950 [details]
Patch

What about ./Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan ?

[Said Abou-Hallawa]

webkit-patch gave a lot of errors before creating the patch and uploading it. But it did create the patch at the end. I am not sure whether this patch can be applied to the webkit repository or not. Everything seems normal when asking "svn stat" from the command line.

I used:

svn move PerformanceTests/Animometer/resources/debug-runner/animometer.css PerformanceTests/Animometer/resources/debug-runner/motionmark.css
svn move PerformanceTests/Animometer/resources/debug-runner/animometer.js PerformanceTests/Animometer/resources/debug-runner/motionmark.js
svn move PerformanceTests/Animometer/resources/runner/animometer.css PerformanceTests/Animometer/resources/runner/motionmark.css
svn move PerformanceTests/Animometer/resources/runner/animometer.js PerformanceTests/Animometer/resources/runner/motionmark.js

svn move PerformanceTests/Animometer/ PerformanceTests/MotionMark/

[Said Abou-Hallawa]

(In reply to comment #2)
> Comment on attachment 297950 [details]
> Patch
> 
> What about
> ./Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan ?

Okay I will change it.

[Said Abou-Hallawa]

Created attachment 297967 [details]
Patch

[Said Abou-Hallawa]

(In reply to comment #4)
> (In reply to comment #2)
> > Comment on attachment 297950 [details]
> > Patch
> > 
> > What about
> > ./Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan ?
> 
> Okay I will change it.

Actually I think I have to wait until this patch landed and then change the plan and the patch files. The plan includes an revision number and a patch file which will be applied on top of this revision to allow running benchmark_runner. So we have to wait until there is a directory called https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/MotionMark in the webkit repository and then create a patch file called "data/patches/MotionMark.patch".

This means benchmark_runner may not be able to run either Animometer or MotionMark temporarily till the new plan and patch are landed. But this should not take that long.

Alternatively we can make a new copy of Animometer to MotionMark in one patch. Add the MotionMark plans and patch in a second patch. Finally delete the Animometer diretcory and the plan and the patch files in a third patch. The downside of this solution is we are going to lose the history for the Animometer.

[Ryosuke Niwa]

We need to first move the directory, and then create a plan file. Regardless, we need update the bot configuration in addition to those changes in order for any change to take effect.

[Said Abou-Hallawa]

To make easy for reviewing this patch, here are the steps I made to made this patch:

git mv PerformanceTests/Animometer/resources/debug-runner/animometer.css PerformanceTests/MotionMark/resources/debug-runner/motionmark.css
git mv PerformanceTests/Animometer/resources/debug-runner/animometer.js PerformanceTests/MotionMark/resources/debug-runner/motionmark.js

git mv PerformanceTests/Animometer/resources/runner/animometer.css PerformanceTests/MotionMark/resources/runner/motionmark.css
git mv PerformanceTests/Animometer/resources/runner/animometer.js PerformanceTests/MotionMark/resources/runner/motionmark.js

git mv PerformanceTests/Animometer/ PerformanceTests/MotionMark/

Then I modified PerformanceTests/MotionMark/developer.html and PerformanceTests/MotionMark/index.html and replaced all "animometer.*" by "motionmark.*".

I also modified PerformanceTests/MotionMark/resources/runner/tests.js by replacing (Suites.push(new Suite("Animometer") by (Suites.push(new Suite("MotionMark").

[WebKit Commit Bot]

Comment on attachment 297967 [details]
Patch

Clearing flags on attachment: 297967

Committed r210459: <http://trac.webkit.org/changeset/210459>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.