ASSIGNED 166641
Reimplement RenderCounter. 
https://bugs.webkit.org/show_bug.cgi?id=166641
Summary Reimplement RenderCounter.
alan baradlay
Reported 2017-01-02 10:04:50 PST
It is mutating the render tree during layout.
Attachments
Patch (73.98 KB, patch)
2017-01-02 10:08 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (77.17 KB, patch)
2017-01-03 22:06 PST, alan baradlay 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-elcapitan (884.84 KB, application/zip)
2017-01-04 11:45 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (898.03 KB, application/zip)
2017-01-04 11:50 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.66 MB, application/zip)
2017-01-04 11:52 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (9.71 MB, application/zip)
2017-01-04 12:01 PST, Build Bot 		no flags
Details
Patch (82.58 KB, patch)
2017-01-06 22:11 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (81.46 KB, patch)
2017-01-07 18:36 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Patch (80.83 KB, patch)
2017-01-08 20:39 PST, alan baradlay 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
alan baradlay
Comment 1 2017-01-02 10:08:34 PST
Created attachment 297903 [details] Patch
alan baradlay
Comment 2 2017-01-02 10:08:55 PST
^^WIP patch.
alan baradlay
Comment 3 2017-01-03 22:06:20 PST
Created attachment 297991 [details] Patch
Build Bot
Comment 4 2017-01-04 11:45:27 PST
Comment on attachment 297991 [details] Patch Attachment 297991 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2829898 New failing tests: css2.1/t1204-implied-02-d.html
Build Bot
Comment 5 2017-01-04 11:45:30 PST
Created attachment 298033 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-01-04 11:50:28 PST
Comment on attachment 297991 [details] Patch Attachment 297991 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2829909 New failing tests: css2.1/t1204-implied-02-d.html
Build Bot
Comment 7 2017-01-04 11:50:32 PST
Created attachment 298034 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 8 2017-01-04 11:52:51 PST
Comment on attachment 297991 [details] Patch Attachment 297991 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2829907 New failing tests: css2.1/t1204-implied-02-d.html
Build Bot
Comment 9 2017-01-04 11:52:54 PST
Created attachment 298035 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 10 2017-01-04 12:01:39 PST
Comment on attachment 297991 [details] Patch Attachment 297991 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2829914 New failing tests: css2.1/t1204-implied-02-d.html
Build Bot
Comment 11 2017-01-04 12:01:42 PST
Created attachment 298036 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
alan baradlay
Comment 12 2017-01-06 22:11:34 PST
Created attachment 298258 [details] Patch
alan baradlay
Comment 13 2017-01-07 18:36:45 PST
Created attachment 298296 [details] Patch
alan baradlay
Comment 14 2017-01-08 20:39:29 PST
Created attachment 298331 [details] Patch
alan baradlay
Comment 15 2020-09-04 19:23:29 PDT
Comment on attachment 298331 [details] Patch test
alan baradlay
Comment 16 2020-09-04 19:28:15 PDT
Comment on attachment 298331 [details] Patch test
alan baradlay
Comment 17 2020-09-04 19:28:54 PDT
Comment on attachment 298331 [details] Patch test
alan baradlay
Comment 18 2020-09-04 19:30:08 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review > Source/WebCore/ChangeLog:8 > + test
alan baradlay
Comment 19 2020-09-04 19:34:51 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review > Source/WebCore/rendering/RenderCounter.cpp:-194 > - if (searchEndRenderer == currentRenderer) { test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test.
alan baradlay
Comment 20 2020-09-04 19:35:50 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review > Source/WebCore/rendering/RenderElement.h:-197 > - void setHasCounterNodeMap(bool f) { m_hasCounterNodeMap = f; } some more test test test test test test test test test test test test test test test.
alan baradlay
Comment 21 2020-09-04 19:36:38 PDT
Comment on attachment 298331 [details] Patch test some more
Darin Adler
Comment 22 2020-09-04 22:45:03 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review > Source/WebCore/ChangeLog:7 > + Next iteration will take care of the vast amount of counter data on RenderElement. test
Simon Fraser (smfr)
Comment 23 2020-09-08 13:27:19 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review >> Source/WebCore/ChangeLog:7 >> + Next iteration will take care of the vast amount of counter data on RenderElement. > > test Test >> Source/WebCore/ChangeLog:8 >> + > > test Test >> Source/WebCore/rendering/RenderCounter.cpp:-194 >> - if (searchEndRenderer == currentRenderer) { > > test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test. i am also testing.
alan baradlay
Comment 24 2020-09-08 13:39:11 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review >>> Source/WebCore/ChangeLog:8 >>> + >> >> test > > Test Test here. >>> Source/WebCore/rendering/RenderCounter.cpp:-194 >>> - if (searchEndRenderer == currentRenderer) { >> >> test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test. > > i am also testing. Some more testing
alan baradlay
Comment 25 2020-09-08 13:41:57 PDT
Comment on attachment 298331 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review >>> Source/WebCore/ChangeLog:7 >>> + Next iteration will take care of the vast amount of counter data on RenderElement. >> >> test > > Test Test >>>> Source/WebCore/ChangeLog:8 >>>> + >>> >>> test >> >> Test > > Test here. Test >>>> Source/WebCore/rendering/RenderCounter.cpp:-194 >>>> - if (searchEndRenderer == currentRenderer) { >>> >>> test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test. >> >> i am also testing. > > Some more testing Testing here too.
Note You need to log in before you can comment on or make changes to this bug.