RESOLVED FIXED 166616
WebAssembly: Some loads don't take into account the offset 
https://bugs.webkit.org/show_bug.cgi?id=166616
Summary WebAssembly: Some loads don't take into account the offset
Saam Barati
Reported 2016-12-29 14:20:50 PST
...
Attachments
patch (4.40 KB, patch)
2017-01-02 12:13 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (4.93 KB, patch)
2017-01-02 15:40 PST, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-12-29 16:51:15 PST
This can be seen my looking at emitLoadOp. This is part of the reason we can't unity. However, there are still other errors I'm hitting after fixing this locally.
Radar WebKit Bug Importer
Comment 2 2017-01-02 11:46:13 PST
<rdar://problem/29841541>
Saam Barati
Comment 3 2017-01-02 12:13:28 PST
Created attachment 297906 [details] patch
JF Bastien
Comment 4 2017-01-02 14:06:09 PST
Comment on attachment 297906 [details] patch lgtm
JF Bastien
Comment 5 2017-01-02 14:06:26 PST
Forgot to ask: are there new spec tests that pass?
Saam Barati
Comment 6 2017-01-02 14:24:51 PST
(In reply to comment #5) > Forgot to ask: are there new spec tests that pass? I didn't try all of them, but memory.wast.js still fails. I can check all of them.
Saam Barati
Comment 7 2017-01-02 15:40:46 PST
Created attachment 297914 [details] patch Two more tests pass for me locally, but I'm not convinced they're related to this patch. They could be tests we forgot to update.
Keith Miller
Comment 8 2017-01-02 15:47:18 PST
Comment on attachment 297914 [details] patch r=me if you add a test for each load.
Saam Barati
Comment 9 2017-01-02 16:33:46 PST
landed in: https://trac.webkit.org/changeset/210228 with tests for all loads that were missing offset.
Note You need to log in before you can comment on or make changes to this bug.