WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
166579
check-webkit-style should not warn about #ifndef header guards in API headers
https://bugs.webkit.org/show_bug.cgi?id=166579
Summary
check-webkit-style should not warn about #ifndef header guards in API headers
Michael Catanzaro
Reported
2016-12-29 08:23:20 PST
check-webkit-style should not warn about #ifndef header guards in API headers: ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitSecurityOriginPrivate.h:20: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] This file is an installed API header, so we shouldn't use #pragma once.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2016-12-29 09:33:30 PST
Well the problem is I can't read, that's the non-installed Private header. It's properly ignoring all the installed headers. The script is correct.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug