Bug 166572 – [css-ui] Implement caret-color support

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Manuel Rego Casasnovas]

"caret-color" has just been implemented on Chromium and Firefox. It'd be really nice if WebKit can support it too.

The spec is CR: https://www.w3.org/TR/css-ui-3/#caret-color

And there are already 21 tests on the W3C csswg-test repo: http://test.csswg.org/shepherd/search/testcase/spec/css-ui-3/section/6.2.1/

[Manuel Rego Casasnovas]

Note that some related stuff was discussed in the past in bug #44862.
Probably it'd be worth to review the comments there, just in case they still apply.

[Daniel Bates]

(In reply to Manuel Rego Casasnovas from comment #1)
> Note that some related stuff was discussed in the past in bug #44862.
> Probably it'd be worth to review the comments there, just in case they still
> apply.

The comments in that bug do not seem applicable to page that explicitly specifies CSS property caret-color. The comments seem applicable to a page that does not explicitly specify CSS property caret-color.

[Daniel Bates]

Created attachment 317833 [details]
Patch and layout tests

[Daniel Bates]

Created attachment 317860 [details]
Patch and layout tests

[Build Bot]

Comment on attachment 317860 [details]
Patch and layout tests

Attachment 317860 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4292159

New failing tests:
fast/events/ondrop-text-html.html
fast/events/before-input-events-prevent-drag-and-drop.html
editing/deleting/maintain-style-after-delete.html
editing/pasteboard/onpaste-text-html.html
editing/style/5065910.html
editing/pasteboard/preserve-underline-color.html
editing/style/5084241.html
editing/pasteboard/do-not-copy-unnecessary-styles-2.html
editing/inserting/insert-paragraph-with-font-and-background-color.html
fast/events/input-events-paste-rich-datatransfer.html

[Build Bot]

Created attachment 317876 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317860 [details]
Patch and layout tests

Attachment 317860 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4292173

New failing tests:
fast/events/ondrop-text-html.html
fast/events/before-input-events-prevent-drag-and-drop.html
editing/deleting/maintain-style-after-delete.html
editing/pasteboard/onpaste-text-html.html
editing/style/5065910.html
editing/pasteboard/preserve-underline-color.html
editing/style/5084241.html
editing/pasteboard/do-not-copy-unnecessary-styles-2.html
editing/inserting/insert-paragraph-with-font-and-background-color.html
fast/events/input-events-paste-rich-datatransfer.html

[Build Bot]

Created attachment 317881 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317860 [details]
Patch and layout tests

Attachment 317860 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4292236

New failing tests:
editing/deleting/maintain-style-after-delete.html
editing/pasteboard/onpaste-text-html.html
editing/style/5065910.html
editing/pasteboard/preserve-underline-color.html
editing/style/5084241.html
editing/pasteboard/do-not-copy-unnecessary-styles-2.html
editing/inserting/insert-paragraph-with-font-and-background-color.html
fast/events/input-events-paste-rich-datatransfer.html

[Build Bot]

Created attachment 317884 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Daniel Bates]

Created attachment 317891 [details]
Patch and layout tests

[Build Bot]

Comment on attachment 317891 [details]
Patch and layout tests

Attachment 317891 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4292996

New failing tests:
fast/events/ondrop-text-html.html

[Build Bot]

Created attachment 317897 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317891 [details]
Patch and layout tests

Attachment 317891 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4293045

New failing tests:
fast/events/ondrop-text-html.html

[Build Bot]

Created attachment 317899 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317891 [details]
Patch and layout tests

Attachment 317891 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4293101

New failing tests:
editing/style/5084241.html

[Build Bot]

Created attachment 317902 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Daniel Bates]

Created attachment 317909 [details]
Patch and layout tests

[Daniel Bates]

Comment on attachment 317909 [details]
Patch and layout tests

I will land updated expected results for iOS WebKitLegacy and GTK bots after landing this patch as we do not have an iOS WebKit1 EWS bot or a GTK bot that runs layout tests. If I have a moment, I will look to build for iOS.

[Dave Hyatt]

Comment on attachment 317909 [details]
Patch and layout tests

r=me, my spider sense is tingling over that disappears into background stuff. I worry there's some kind of attack possible there to detect a link is in history.

[Radar WebKit Bug Importer]

<rdar://problem/33852589>

[Daniel Bates]

Committed r220706: <http://trac.webkit.org/changeset/220706>

[Daniel Bates]

Committed updated GTK expected results in <http://trac.webkit.org/changeset/220714>.