Bug 166539 - GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion
Summary: GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder dive...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-28 10:06 PST by Zan Dobersek
Modified: 2017-01-01 08:47 PST (History)
0 users

See Also:

Attachments
Patch (1.55 KB, patch)
2016-12-28 10:12 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (1.44 KB, patch)
2017-01-01 08:13 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-12-28 10:06:38 PST 
GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion
Comment 1 Zan Dobersek 2016-12-28 10:12:42 PST 
Created attachment 297815 [details]
Patch
Comment 2 Michael Catanzaro 2016-12-28 11:12:21 PST 
Comment on attachment 297815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297815&action=review

The amount of code duplication between these classes is quite worrisome. Things are just going to get desynced again in the future. :/

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1021
> +        m_displayListRecorder->setMiterLimit(limit);

EWS is red: limit was not declared in this scope. The parameter is named differently here than in GraphicsContextCG.
Comment 3 Zan Dobersek 2017-01-01 08:08:52 PST 
(In reply to comment #2)
> Comment on attachment 297815 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297815&action=review
> 
> The amount of code duplication between these classes is quite worrisome.
> Things are just going to get desynced again in the future. :/
> 

True, maybe a recording-specific GraphicsContext class could work.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1021
> > +        m_displayListRecorder->setMiterLimit(limit);
> 
> EWS is red: limit was not declared in this scope. The parameter is named
> differently here than in GraphicsContextCG.

Oops!
Comment 4 Zan Dobersek 2017-01-01 08:13:25 PST 
Created attachment 297873 [details]
Patch for landing
Comment 5 Zan Dobersek 2017-01-01 08:47:29 PST 
Comment on attachment 297873 [details]
Patch for landing

Clearing flags on attachment: 297873

Committed r210220: <http://trac.webkit.org/changeset/210220>
Comment 6 Zan Dobersek 2017-01-01 08:47:37 PST 
All reviewed patches have been landed.  Closing bug.